Update Jenkinsfile to use maven settings helper

gracechensd · edenhill · commit 9d75ee91951f · 2022-01-29T00:20:25.000+01:00
Use the maven settings helper function [withMavenSettings()](https://github.com/confluentinc/jenkins-common/pull/415) which avoids including hardcoded credentials in our vault secrets.
diff --git a/tests/system/Jenkinsfile b/tests/system/Jenkinsfile
@@ -9,15 +9,16 @@ def config = jobConfig {
 
 def job = {
     configureGitSSH("github/confluent_jenkins", "private_key")
+    def mavenSettingsFile = "/home/jenkins/.m2/settings.xml"
     withVaultEnv([["artifactory/tools_jenkins", "user", "TOOLS_ARTIFACTORY_USER"],
         ["artifactory/tools_jenkins", "password", "TOOLS_ARTIFACTORY_PASSWORD"],
         ["sonatype/confluent", "user", "SONATYPE_OSSRH_USER"],
         ["sonatype/confluent", "password", "SONATYPE_OSSRH_PASSWORD"]]) {
-        withVaultFile([["maven/jenkins_maven_global_settings", "settings_xml",
-            "/home/jenkins/.m2/settings.xml", "MAVEN_GLOBAL_SETTINGS"],
-            ["muckrake/2017-06-01", "pem", "muckrake-2017-06-01.pem", "MUCKRAKE_PEM"]]) {
-            stage("Run tests") {
-                sh 'tests/system/run-tests.sh'
+        withVaultFile([["muckrake/2017-06-01", "pem", "muckrake-2017-06-01.pem", "MUCKRAKE_PEM"]]) {
+            withMavenSettings("maven/jenkins_maven_global_settings", "settings", "MAVEN_GLOBAL_SETTINGS", mavenSettingsFile) {
+                stage("Run tests") {
+                    sh 'tests/system/run-tests.sh'
+                }
             }
         }
     }
