Fix KafkaError refcounting

edenhill · edenhill · commit 136efd3d83e3 · 2018-05-21T12:10:08.000+02:00
diff --git a/confluent_kafka/src/Admin.c b/confluent_kafka/src/Admin.c
@@ -1489,13 +1489,14 @@ static void Admin_event_cb (rd_kafka_t *rk, rd_kafka_event_t *rkev,
 
         /* Create a new exception based on exception type and error. */
         excargs = PyTuple_New(1);
+        Py_INCREF(error); /* tuple's reference */
         PyTuple_SET_ITEM(excargs, 0, error);
         exc = ((PyTypeObject *)exctype)->tp_new(
                 (PyTypeObject *)exctype, NULL, NULL);
         exc->ob_type->tp_init(exc, excargs, NULL);
         Py_DECREF(excargs);
         Py_XDECREF(exctype);
-        Py_XDECREF(error);
+        Py_XDECREF(error); /* from error source above */
 
         /*
          * Call future.set_exception(exc)
diff --git a/confluent_kafka/src/confluent_kafka.h b/confluent_kafka/src/confluent_kafka.h
@@ -163,7 +163,6 @@ PyObject *KafkaError_new_or_None (rd_kafka_resp_err_t err, const char *str);
 #define cfl_PyErr_Format(err,...) do {					\
 		PyObject *_eo = KafkaError_new0(err, __VA_ARGS__);	\
 		PyErr_SetObject(KafkaException, _eo);			\
-		Py_DECREF(_eo); \
 	} while (0)
 
 
