Added get_schema_by_version method to the cached schema registry client

javier.pardo · javier.pardo · commit e3d601f7d184 · 2018-12-06T16:56:13.000+01:00
diff --git a/confluent_kafka/avro/cached_schema_registry_client.py b/confluent_kafka/avro/cached_schema_registry_client.py
@@ -276,7 +276,10 @@ def get_by_id(self, schema_id):
                 # bad schema - should not happen
                 raise ClientError("Received bad schema (id %s) from registry: %s" % (schema_id, e))
 
-    def get_latest_schema(self, subject):
+
+    
+    
+    def get_schema_by_version(self, subject, version):
         """
         GET /subjects/(string: subject)/versions/(versionId: version)
 
@@ -291,7 +294,7 @@ def get_latest_schema(self, subject):
         :returns: (schema_id, schema, version)
         :rtype: (string, schema, int)
         """
-        url = '/'.join([self.url, 'subjects', subject, 'versions', 'latest'])
+        url = '/'.join([self.url, 'subjects', subject, 'versions', version])
 
         result, code = self._send_request(url)
         if code == 404:
@@ -315,6 +318,25 @@ def get_latest_schema(self, subject):
 
         self._cache_schema(schema, schema_id, subject, version)
         return (schema_id, schema, version)
+    
+
+    def get_latest_schema(self, subject):
+        """
+        GET /subjects/(string: subject)/versions/(versionId: version)
+
+        Return the latest 3-tuple of:
+        (the schema id, the parsed avro schema, the schema version)
+        for a particular subject.
+
+        This call always contacts the registry.
+
+        If the subject is not found, (None,None,None) is returned.
+        :param str subject: subject name
+        :returns: (schema_id, schema, version)
+        :rtype: (string, schema, int)
+        """
+        return self.get_schema_by_version(subject, 'latest')
+    
 
     def get_version(self, subject, avro_schema):
         """
