-
Notifications
You must be signed in to change notification settings - Fork 890
Added https://jsonapi-validator.herokuapp.com service to implementations #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added jsonapi-validator service to Related tools section of jsonapi.org/implementations - Placed under Implementations > Related Tools > Playground - Link to the service is https://jsonapi-validator.herokuapp.com
This looks good to me. |
Is it open source? (Like, can I see if the validations look right to me? ref #1098 ) What's the license? |
Within the validator it links to the github repo with the underlying code available in an open public repo, so I'd say yes it is. Repo here - https://github.com/karthikselva/jsonapi-validator-service. For specific licence you might want to just raise an issue on the project itself. Im guessing your comments aren't blocking concerns with regards to including a link to this resource in the project help files is it? This is still a simple merge and a useful link to share under resources in my opinion. |
@bf4 Added MIT License, please let me know if I am missing something |
@evolve2k @karthikselva (I don't have commit. was just asking) |
Is this just a web app that applies a json schema validator to the schema file in this repo? That schema is neither complete nor authoritative. (That's why I was interested in the source. No one has published anything authoritative or comprehensive yet.) |
re: authoritative #440 (comment) and ref: some earlier discussion of the schema #867 |
@bf4 Cool thanks 👍 |
Thanks for the PR @karthikselva and the discussion @bf4. I'm thinking the question of what constitutes a proper validator requires ongoing discussion and is probably better suited for discussion elsewhere. Backing @steveklabnik's tweet comments, I can't see any issue with adding this link under related tools playground. Considerations for how to best validate JSONAPI spec are defintley of interest to me. http://discuss.jsonapi.org/t/how-to-validate-the-json-api-format/147 @bf4 it might even be better to pose your own question on the forums so we can best narrow in on how to progress this. Admins, lets get this link merged! |
After all the discussion, I forgot to come back and merge this. Sorry for the delay. And thanks for great validator! 💯 |
All good. Thanks for being a fab open source peep. 🤘 |
jsonapi.org/implementations