Skip to content

Add server responsibility to reject unsupported, extended requests. #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

gabesullice
Copy link
Contributor

Thanks to an astute comment by @freddrake in #1436 (direct link), @dgeb and I realized that the recent addition of extension negotiation to the 1.1 spec (#1457) was lacking a detail to aid client-server content negotiation. Namely, that the server must respond with a client error status code if the client sends an extended media type parameter with an unsupported extension. This PR adds the needed normative statement:

If a request specifies the Content-Type header with an instance of
the JSON:API media type modified by the ext media type parameter and that
parameter contains an unsupported extension URI, the server MUST respond
with a 415 Unsupported Media Type status code.

Copy link
Member

@dgeb dgeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this nails it. Thanks @gabesullice!

@gabesullice gabesullice merged commit 74b0580 into gh-pages Feb 26, 2020
@dgeb dgeb deleted the content-type-ext-responsibilities branch February 26, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy