Skip to content

allow relationship paths in query parameter families #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Apr 21, 2023

This fixes a bug introduced in v1.1 preventing the use of relationship paths in filtering. Please see #1689 for details.

TODO:

  • Backport to v1.1

Closes #1689

@jelhan jelhan requested a review from dgeb April 21, 2023 21:39
@cmeeren
Copy link
Contributor

cmeeren commented Apr 22, 2023

While we're on the topic: What is actually the reason for limiting the values in []? Why not just allow arbitrary values?

@json-api json-api deleted a comment from Faih4440 Jun 5, 2023
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see this back ported to v1.1

@jelhan jelhan merged commit d990fe5 into gh-pages Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.1 spec disallows e.g. filter[author.name]
4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy