Always make a submission copy.

fkdosilovic · fkdosilovic · commit 99e36eff7fdd · 2024-11-25T17:13:35.000+01:00
diff --git a/examples/0001_hello_world.py b/examples/0001_hello_world.py
@@ -6,6 +6,6 @@
 )
 
 # Run submission on CE flavor of judge0.
-judge0.run(submissions=submission)
+submission = judge0.run(submissions=submission)
 
 print(submission.stdout)
diff --git a/examples/0002_hello_world.py b/examples/0002_hello_world.py
@@ -6,6 +6,6 @@
 )
 
 # Instead of relying on the CE flavor of judge0, we can use EXTRA_CE.
-judge0.run(client=judge0.EXTRA_CE, submissions=submission)
+submission = judge0.run(client=judge0.EXTRA_CE, submissions=submission)
 
 print(submission.stdout)
diff --git a/examples/0003_hello_world.py b/examples/0003_hello_world.py
@@ -5,6 +5,6 @@
     language=judge0.PYTHON,
 )
 
-judge0.run(submissions=submission)
+submission = judge0.run(submissions=submission)
 
 print(submission.stdout)
diff --git a/examples/0004_hello_world.py b/examples/0004_hello_world.py
@@ -1,4 +1,4 @@
 import judge0
 
-result = judge0.run(source_code="print('Hello Judge0')")
-print(result.stdout)
+submission = judge0.run(source_code="print('Hello Judge0')")
+print(submission.stdout)
diff --git a/src/judge0/api.py b/src/judge0/api.py
@@ -160,12 +160,6 @@ def create_submissions_from_test_cases(
     | Submissions | TestCases  | Submissions |
 
     """
-    # Let's deal with the simplest cases where no test cases are provided. We
-    # return original submissions argument as this gives a user an option
-    # to change the original Submission objects, without creating copies of it.
-    if test_cases is None or isinstance(test_cases, list) and len(test_cases) == 0:
-        return submissions
-
     if isinstance(submissions, Submission):
         submissions_list = [submissions]
     else:
@@ -185,7 +179,9 @@ def create_submissions_from_test_cases(
                 submission_copy.expected_output = test_case.expected_output
             all_submissions.append(submission_copy)
 
-    if isinstance(submissions, Submission) and isinstance(test_cases, TestCase):
+    if isinstance(submissions, Submission) and (
+        isinstance(test_cases, TestCase) or test_cases is None
+    ):
         return all_submissions[0]
     else:
         return all_submissions
diff --git a/tests/test_api_test_cases.py b/tests/test_api_test_cases.py
@@ -121,10 +121,9 @@ def test_test_cases_from_run(
     ],
 )
 def test_no_test_cases(submissions, expected_status, request):
-    """This test tests that if no test cases are provided, the submissions are changed in place."""
     client = request.getfixturevalue("judge0_ce_client")
 
-    judge0.run(
+    submissions = judge0.run(
         client=client,
         submissions=submissions,
     )

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,6 @@`
`6`	`6`	`)`
`7`	`7`
`8`	`8`	`# Run submission on CE flavor of judge0.`
`9`		`-judge0.run(submissions=submission)`
	`9`	`+submission = judge0.run(submissions=submission)`
`10`	`10`
`11`	`11`	`print(submission.stdout)`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,6 @@`
`6`	`6`	`)`
`7`	`7`
`8`	`8`	`# Instead of relying on the CE flavor of judge0, we can use EXTRA_CE.`
`9`		`-judge0.run(client=judge0.EXTRA_CE, submissions=submission)`
	`9`	`+submission = judge0.run(client=judge0.EXTRA_CE, submissions=submission)`
`10`	`10`
`11`	`11`	`print(submission.stdout)`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,6 @@`
`5`	`5`	`language=judge0.PYTHON,`
`6`	`6`	`)`
`7`	`7`
`8`		`-judge0.run(submissions=submission)`
	`8`	`+submission = judge0.run(submissions=submission)`
`9`	`9`
`10`	`10`	`print(submission.stdout)`
Original file line number	Diff line number	Diff line change
`@@ -121,10 +121,9 @@ def test_test_cases_from_run(`
`121`	`121`	`],`
`122`	`122`	`)`
`123`	`123`	`def test_no_test_cases(submissions, expected_status, request):`
`124`		`- """This test tests that if no test cases are provided, the submissions are changed in place."""`
`125`	`124`	`client = request.getfixturevalue("judge0_ce_client")`
`126`	`125`
`127`		`- judge0.run(`
	`126`	`+ submissions = judge0.run(`
`128`	`127`	`client=client,`
`129`	`128`	`submissions=submissions,`
`130`	`129`	`)`