Unit tests for Bank account type and BankAccountType enum definition fix

vkandroiddev · vkandroiddev · commit 12eafad4dd9c · 2014-03-27T16:14:47.000-07:00
diff --git a/src/main/java/net/authorize/arb/Transaction.java b/src/main/java/net/authorize/arb/Transaction.java
@@ -319,7 +319,7 @@ else if (bank_account != null) {
 
 			if(bank_account.getBankAccountType() != null) {
 				Element account_type_el = document.createElement(AuthNetField.ELEMENT_ACCOUNT_TYPE.getFieldName());
-				account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue2()));
+				account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue()));
 				bankacct_el.appendChild(account_type_el);
 			}
 
diff --git a/src/main/java/net/authorize/cim/Transaction.java b/src/main/java/net/authorize/cim/Transaction.java
@@ -343,7 +343,7 @@ else if (bank_account != null) {
 
 			if(bank_account.getBankAccountType() != null) {
 				Element account_type_el = document.createElement(AuthNetField.ELEMENT_ACCOUNT_TYPE.getFieldName());
-				account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue2()));
+				account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue()));
 				bankacct_el.appendChild(account_type_el);
 			}
 
diff --git a/src/main/java/net/authorize/data/echeck/BankAccountType.java b/src/main/java/net/authorize/data/echeck/BankAccountType.java
@@ -7,10 +7,10 @@
  *
  */
 public enum BankAccountType implements Serializable {
-	CHECKING("CHECKING","checking"),
-	BUSINESSCHECKING("BUSINESSCHECKING","businessChecking"),
-	SAVINGS("SAVINGS","savings"),
-	UNKNOWN("UNKNOWN","unknown");
+	CHECKING("checking", "CHECKING"),
+	BUSINESSCHECKING("businessChecking","BUSINESSCHECKING"),
+	SAVINGS("savings","SAVINGS"),
+	UNKNOWN("unknown","UNKNOWN");
 
 	private final String value;
 	private final String value2;
@@ -38,11 +38,6 @@ public String getValue() {
 		return value;
 	}
 	
-	/**
-	 * @return the value2
-	 */
-	public String getValue2() {
-		return value2;
-	}
+
 
 }
diff --git a/src/test/java/net/authorize/cim/functional_test/CIMTest.java b/src/test/java/net/authorize/cim/functional_test/CIMTest.java
@@ -75,10 +75,10 @@ public void setUp() throws Exception {
 		bankAccount = BankAccount.createBankAccount();
 		bankAccount.setBankAccountName(bankAccountName);
 		bankAccount.setBankAccountNumber(bankAccountNumber);
-		bankAccount.setBankAccountType(BankAccountType.CHECKING);
+		bankAccount.setBankAccountType(BankAccountType.BUSINESSCHECKING);
 		bankAccount.setBankName(bankName);
 		bankAccount.setRoutingNumber(routingNumber);
-		bankAccount.setECheckType(ECheckType.WEB);
+		bankAccount.setECheckType(ECheckType.CCD);
 
 		// Create a billing info
 		//
@@ -683,7 +683,7 @@ public void testUpdateCustomerPaymentProfileRequest() {
 		ArrayList<Payment> pl = paymentProfileCC.getPaymentList();
 		Payment p  = pl.get(0);
 		if(p.getCreditCard()!=null)
-			{p.getCreditCard().setExpirationDate("XXXX");}
+			{p.getCreditCard().setExpirationDate(CreditCard.MASKED_EXPIRY_DATE);}
 		transaction.setValidationMode(ValidationModeType.TEST_MODE);
 
 		Result<Transaction> result = (Result<Transaction>) merchant

Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,7 @@ else if (bank_account != null) {`
`319`	`319`
`320`	`320`	`if(bank_account.getBankAccountType() != null) {`
`321`	`321`	`Element account_type_el = document.createElement(AuthNetField.ELEMENT_ACCOUNT_TYPE.getFieldName());`
`322`		`- account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue2()));`
	`322`	`+ account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue()));`
`323`	`323`	`bankacct_el.appendChild(account_type_el);`
`324`	`324`	`}`
`325`	`325`
Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,7 @@ else if (bank_account != null) {`
`343`	`343`
`344`	`344`	`if(bank_account.getBankAccountType() != null) {`
`345`	`345`	`Element account_type_el = document.createElement(AuthNetField.ELEMENT_ACCOUNT_TYPE.getFieldName());`
`346`		`- account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue2()));`
	`346`	`+ account_type_el.appendChild(document.getDocument().createTextNode(bank_account.getBankAccountType().getValue()));`
`347`	`347`	`bankacct_el.appendChild(account_type_el);`
`348`	`348`	`}`
`349`	`349`