fix(json-api-nestjs-microorm): ensure applyFilters is invoked in query builders for consistency

klerick · klerick · commit 391f4bb45bc9 · 2025-06-10T12:32:47.000+02:00
diff --git a/libs/json-api/json-api-nestjs-microorm/src/lib/factory/index.ts b/libs/json-api/json-api-nestjs-microorm/src/lib/factory/index.ts
@@ -154,12 +154,11 @@ export function FindOneRowEntityFactory<
     inject: [MicroOrmUtilService],
     useFactory(microOrmUtilService: MicroOrmUtilService<E, IdKey>) {
       return async (entity, value) => {
-        return microOrmUtilService
-          .queryBuilder(entity)
-          .where({
-            [microOrmUtilService.currentPrimaryColumn]: value,
-          })
-          .getSingleResult();
+        const qb = microOrmUtilService.queryBuilder(entity).where({
+          [microOrmUtilService.currentPrimaryColumn]: value,
+        });
+        await qb.applyFilters();
+        return qb.getSingleResult();
       };
     },
   };
diff --git a/libs/json-api/json-api-nestjs-microorm/src/lib/orm-methods/get-all/get-all.ts b/libs/json-api/json-api-nestjs-microorm/src/lib/orm-methods/get-all/get-all.ts
@@ -19,6 +19,9 @@ export async function getAll<E extends object, IdKey extends string>(
   >(this, ...[query]);
 
   const skip = (page.number - 1) * page.size;
+
+  await countSubQuery.applyFilters();
+
   const paginationQuery = countSubQuery
     .clone()
     .select(this.microOrmUtilService.currentPrimaryColumn)
diff --git a/libs/json-api/json-api-nestjs-microorm/src/lib/orm-methods/get-one/get-one.ts b/libs/json-api/json-api-nestjs-microorm/src/lib/orm-methods/get-one/get-one.ts
@@ -12,10 +12,14 @@ export async function getOne<E extends object, IdKey extends string>(
     [this.microOrmUtilService.currentPrimaryColumn]: id,
   });
 
-  const resultItem = await this.microOrmUtilService
-    .prePareQueryBuilder(queryBuilder, query as any)
-    .getSingleResult();
+  const resultQueryBuilder = this.microOrmUtilService.prePareQueryBuilder(
+    queryBuilder,
+    query as any
+  );
 
+  await resultQueryBuilder.applyFilters();
+
+  const resultItem = await resultQueryBuilder.getSingleResult();
   if (!resultItem) {
     const error: ValidateQueryError = {
       code: 'invalid_arguments',
