Update 347-Top-K-Frequent-Elements.js

rutanshuj · web-flow · commit b045b9e19f65 · 2022-07-25T23:05:30.000-04:00
1) Last inner "for" loop, checking whether threshold and response array 's lengths are equal, does not need condition as  the response can be in any order, hence "if-condition" can be placed outside.
2) Instead of Map functions we can used basic JS object functions.
3) Few other changes  - Spelling mistake(s), variable declaration changes in for-loop.
diff --git a/javascript/347-Top-K-Frequent-Elements.js b/javascript/347-Top-K-Frequent-Elements.js
@@ -4,26 +4,26 @@
  * @return {number[]}
  */
 var topKFrequent = function (nums, k) {
-    let map = new Map();
+    let map = {};
     let res = [];
     let bucket = Array.from({ length: nums.length + 1 }, () => []); // to create unique arrays
 
     // storing frequency of numbers in a map
-    for (let n of nums) {
-        map.set(n, map.has(n) ? 1 + map.get(n) : 1);
+    for (const n of nums) {
+        map[n] = (n in map) ? 1 + map[n] : 1;
     }
 
-    // Poppulate the bucket with numbers in frequency
+    // Populate the bucket with numbers in frequency
     // as the index of the bucket
-    for (const [key, value] of map.entries()) {
-        bucket[value].push(key);
+    for(const c in map){
+        bucket[map[c]].push(c);
     }
-
+    
     for (let i = bucket.length - 1; i >= 0; i--) {
         if (bucket[i].length > 0) {
-            for (let n of bucket[i]) {
-                res.push(n);
-                if (res.length === k) return res;
+            bucket[i].forEach((elem)=> res.push(elem));
+            if(k == res.length){
+                return res;
             }
         }
     }
