Merge pull request influxdata#216 from influxdb/215

aviau · aviau · commit 19501123fb7f · 2015-07-19T18:35:27.000-04:00
Dont include empty tags in lines (Closes: influxdata#215)
diff --git a/influxdb/line_protocol.py b/influxdb/line_protocol.py
@@ -79,10 +79,10 @@ def make_lines(data):
             tags.update(point.get('tags', {}))
         # tags should be sorted client-side to take load off server
         for tag_key in sorted(tags.keys()):
-            lines += "{key}={value},".format(
-                key=_escape_tag(tag_key),
-                value=_escape_tag(tags[tag_key]),
-            )
+            key = _escape_tag(tag_key)
+            value = _escape_tag(tags[tag_key])
+            if key != '' and value != '':
+                lines += "{key}={value},".format(key=key, value=value)
         lines = lines[:-1] + " "  # strip the trailing comma
 
         # add fields
diff --git a/tests/influxdb/test_line_protocol.py b/tests/influxdb/test_line_protocol.py
@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+
+import unittest
+from influxdb import line_protocol
+
+
+class TestLineProtocol(unittest.TestCase):
+
+    def test_empty_tag(self):
+        data = {
+            "tags": {
+                "my_tag": ""
+            },
+            "points": [
+                {
+                    "measurement": "test",
+                    "fields": {
+                        "value": "hello!"
+                    }
+                }
+            ]
+        }
+
+        self.assertEqual(
+            line_protocol.make_lines(data),
+            'test value="hello!"\n'
+        )
