Removed duplicate call to sys.stdout.fileno() in setup_logging.setup_logging().

zakv · zakv · commit c4dd2a83bdcf · 2021-11-10T12:15:34.000-05:00
Probably best practice to call it just once rather than calling it first to check if it raises an error then again later to actually use the value it returns.
diff --git a/labscript_utils/setup_logging.py b/labscript_utils/setup_logging.py
@@ -57,15 +57,15 @@ def setup_logging(program_name, log_level=logging.DEBUG, terminal_level=logging.
     try:
         # Check that sys.stdout.fileno is callable, which is needed below. It is NOT
         # callable in Jupyter notebooks.
-        sys.stdout.fileno()
+        stdout_fileno = sys.stdout.fileno()
     except UnsupportedOperation:
         # In this case the code is likely being run from a Jupyter notebook, warn the
         # user that log messages won't be printed to stdout or stderr.
         warnings.warn(
             "Logging to stdout and stderr is disabled. See the log files for log messages."
         )
     else:
-        if sys.stdout is not None and sys.stdout.fileno() >= 0:
+        if sys.stdout is not None and stdout_fileno >= 0:
             stdout_handler = logging.StreamHandler(sys.stdout)
             stdout_handler.setFormatter(formatter)
             stdout_handler.setLevel(terminal_level)
