fix: custom relationship meta not returned on paginated responses (#23)

haddowg · Gregory Haddow · web-flow · commit 902408acc3c1 · 2025-01-11T17:34:29.000Z
Co-authored-by: Gregory Haddow &lt;gregory.haddow@chatloop.com&gt;
diff --git a/src/Core/Responses/Concerns/HasRelationship.php b/src/Core/Responses/Concerns/HasRelationship.php
@@ -48,7 +48,7 @@ private function allMeta(): ?Hash
      *
      * @return array|null
      */
-    private function metaForRelationship(): ?array
+    protected function metaForRelationship(): ?array
     {
         if ($this->hasRelationMeta && $relation = $this->relation()) {
             return $relation->meta();
diff --git a/src/Core/Responses/Internal/PaginatedIdentifierResponse.php b/src/Core/Responses/Internal/PaginatedIdentifierResponse.php
@@ -43,6 +43,8 @@ public function __construct(JsonApiResource $resource, string $fieldName, Page $
     public function meta(): Hash
     {
         return Hash::cast($this->page->meta())->merge(
+            Hash::cast(parent::metaForRelationship())
+        )->merge(
             parent::meta()
         );
     }
diff --git a/src/Core/Responses/Internal/PaginatedRelatedResourceResponse.php b/src/Core/Responses/Internal/PaginatedRelatedResourceResponse.php
@@ -43,6 +43,8 @@ public function __construct(JsonApiResource $resource, string $fieldName, Page $
     public function meta(): Hash
     {
         return Hash::cast($this->page->meta())->merge(
+            Hash::cast(parent::metaForRelationship())
+        )->merge(
             parent::meta()
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ private function allMeta(): ?Hash`
`48`	`48`	`*`
`49`	`49`	`* @return array\|null`
`50`	`50`	`*/`
`51`		`- private function metaForRelationship(): ?array`
	`51`	`+ protected function metaForRelationship(): ?array`
`52`	`52`	`{`
`53`	`53`	`if ($this->hasRelationMeta && $relation = $this->relation()) {`
`54`	`54`	`return $relation->meta();`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,8 @@ public function __construct(JsonApiResource $resource, string $fieldName, Page $`
`43`	`43`	`public function meta(): Hash`
`44`	`44`	`{`
`45`	`45`	`return Hash::cast($this->page->meta())->merge(`
	`46`	`+ Hash::cast(parent::metaForRelationship())`
	`47`	`+ )->merge(`
`46`	`48`	`parent::meta()`
`47`	`49`	`);`
`48`	`50`	`}`