fix: remove deprecation notices in php 8.4

lindyhopchris · lindyhopchris · commit 0e890e84e604 · 2024-11-29T17:20:58.000Z
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.2, 8.3]
+        php: [8.2, 8.3, 8.4]
         laravel: [11]
 
     steps:
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. This projec
 
 ## Unreleased
 
+### Fixed
+
+- Remove deprecation notices for PHP 8.4.
+
 ## [3.0.0] - 2024-03-12
 
 ### Changed
diff --git a/composer.json b/composer.json
@@ -27,8 +27,8 @@
         "ext-json": "*",
         "illuminate/contracts": "^11.0",
         "illuminate/pipeline": "^11.0",
-        "laravel-json-api/core": "^4.0",
-        "laravel-json-api/validation": "^4.0"
+        "laravel-json-api/core": "^4.3.2",
+        "laravel-json-api/validation": "^4.2"
     },
     "require-dev": {
         "laravel-json-api/testing": "^3.0",
diff --git a/phpunit.xml b/phpunit.xml
@@ -13,6 +13,7 @@
          failOnWarning="true"
          failOnDeprecation="true"
          failOnNotice="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
 >
     <coverage/>
     <testsuites>
diff --git a/src/Pipes/ValidationExceptionHandler.php b/src/Pipes/ValidationExceptionHandler.php
@@ -36,7 +36,7 @@ class ValidationExceptionHandler
      */
     public function __construct(
         private readonly Factory $factory,
-        Translator $translator = null,
+        ?Translator $translator = null,
     ) {
         $this->translator = $translator;
     }

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`failOnWarning="true"`
`14`	`14`	`failOnDeprecation="true"`
`15`	`15`	`failOnNotice="true"`
	`16`	`+ displayDetailsOnTestsThatTriggerDeprecations="true"`
`16`	`17`	`>`
`17`	`18`	`<coverage/>`
`18`	`19`	`<testsuites>`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ class ValidationExceptionHandler`
`36`	`36`	`*/`
`37`	`37`	`public function __construct(`
`38`	`38`	`private readonly Factory $factory,`
`39`		`- Translator $translator = null,`
	`39`	`+ ?Translator $translator = null,`
`40`	`40`	`) {`
`41`	`41`	`$this->translator = $translator;`
`42`	`42`	`}`