Changing workflow arguments during processing / N users have to accept #200

Cluster2a · 2025-01-25T18:35:36Z

Cluster2a
Jan 25, 2025

Hey! First of all, I wanted to thank you for the practical project—amazing work!

Now to my question: I have a vacation approval workflow that needs to be confirmed by N users. For this, I pass a list of user IDs as an array as a workflow argument.

Multiple users can send a signal (including their user ID), but I’d never know when all users in the initial array have actually confirmed.

Where should this information be stored? Possibly somewhere outside the workflow? I was considering whether I could modify the arguments within the workflow itself. For example, if user XXX confirms, I’d check if they’re in the list and remove them. Once the list is empty, the workflow would be considered complete.

What would be the ideal solution for this? @rmcdaniel :)

Best - Alex

Answered by rmcdaniel

Jan 25, 2025

use Workflow\SignalMethod;
use Workflow\Workflow;
use Workflow\WorkflowStub;

class VacationApprovalWorkflow extends Workflow
{
    private int $approvalCount = 0;

    #[SignalMethod]
    public function approve()
    {
        $this->approvalCount++;
    }

    public function execute(int $requiredApprovals)
    {
        yield WorkflowStub::await(fn () => $this->approvalCount >= $requiredApprovals);

        // Proceed with workflow completion once approvals are met
        $this->finalizeApproval();
    }

    private function finalizeApproval()
    {
        echo "Vacation approved by required number of users.";
    }
}

So here is a simple example workflow that counts the number of …

View full answer

rmcdaniel · 2025-01-25T23:23:12Z

rmcdaniel
Jan 25, 2025
Maintainer

use Workflow\SignalMethod;
use Workflow\Workflow;
use Workflow\WorkflowStub;

class VacationApprovalWorkflow extends Workflow
{
    private int $approvalCount = 0;

    #[SignalMethod]
    public function approve()
    {
        $this->approvalCount++;
    }

    public function execute(int $requiredApprovals)
    {
        yield WorkflowStub::await(fn () => $this->approvalCount >= $requiredApprovals);

        // Proceed with workflow completion once approvals are met
        $this->finalizeApproval();
    }

    private function finalizeApproval()
    {
        echo "Vacation approved by required number of users.";
    }
}

So here is a simple example workflow that counts the number of approval signals received and then only completes after the minimum number of approvals has been received.

use Workflow\WorkflowStub;

$workflow = WorkflowStub::make(VacationApprovalWorkflow::class);
$workflow->start(3); // Requires 3 approvals

$workflow->approve(); // First user approves
$workflow->approve(); // Second user approves
$workflow->approve(); // Third user approves, workflow completes

4 replies

Cluster2a Jan 26, 2025
Author

@rmcdaniel, I think I am missing something.
I am working with a inquiries table where the users enters the dates he wants to take off and then the user can start the workflow.
Now I am writing the workflow_id to the created record.

Working with class variables works only If I have the original workflow object.

Another User could only send the Signal to a new Instance of the workflow, right?

// User 1
$workflow = WorkflowStub::load(1); // approvalCount = 0 again
$workflow->approve();

// User 2
$workflow = WorkflowStub::load(1); // approvalCount = 0 again
$workflow->approve();

So I am not sure how to overcome this..

rmcdaniel Jan 26, 2025
Maintainer

@Cluster2a Loading the workflow by the id and sending an approve() signal should work. Please double check everything. Let me know if it's still not working.

Cluster2a Jan 26, 2025
Author

@rmcdaniel, you’re absolutely right! I must have overlooked something while debugging, but I can now see that the counter reflects the latest value. Thanks so much for your help!

By the way, we plan to incorporate this package into our solution and intend to sponsor this project regularly. Thank you for creating such a useful tool!

rmcdaniel Jan 26, 2025
Maintainer

@Cluster2a That's great to hear. You're welcome to join the Discord as well. You can usually get a faster response there. Thanks!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Changing workflow arguments during processing / N users have to accept #200

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment 4 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

Changing workflow arguments during processing / N users have to accept #200

Uh oh!

Uh oh!

Cluster2a Jan 25, 2025

Replies: 1 comment · 4 replies

Uh oh!

Uh oh!

rmcdaniel Jan 25, 2025 Maintainer

Uh oh!

Uh oh!

Cluster2a Jan 26, 2025 Author

Uh oh!

rmcdaniel Jan 26, 2025 Maintainer

Uh oh!

Cluster2a Jan 26, 2025 Author

Uh oh!

rmcdaniel Jan 26, 2025 Maintainer

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Cluster2a
Jan 25, 2025

Replies: 1 comment 4 replies

rmcdaniel
Jan 25, 2025
Maintainer

Cluster2a Jan 26, 2025
Author

rmcdaniel Jan 26, 2025
Maintainer

Cluster2a Jan 26, 2025
Author

rmcdaniel Jan 26, 2025
Maintainer