Sorry for the delay. I have not forgotten about this!

Thank you! This will be a helpful addition to this project.

Would you consider making an interface/contract that can mark any exception class as NonRetryable? That would allow us to make any existing exception class NonRetryable without having to extend the NonRetryable class (which may be difficult if the exception is already extending a different base class).

Here's what it would look like:

NonRetryableException.php:

<?php

declare(strict_types=1);

namespace Workflow\Exceptions;

use Exception;
use Throwable;

class NonRetryableException extends Exception implements NonRetryableExceptionContract
{
    public function __construct($message = '', $code = 0, Throwable $previous = null)
    {
        parent::__construct($message, $code, $previous);
    }
}

NonRetryableExceptionContract.php:

<?php

declare(strict_types=1);

namespace Workflow\Exceptions;

interface NonRetryableExceptionContract {}

In Activity.php, you'd catch the exceptions with:

if ($throwable instanceof NonRetryableExceptionContract) {
    $this->fail($throwable);
}

With this change, you can still throw a NonRetryableException to fail an activity. If there are other exceptions in a project that should fail an activity, you can simply add implements NonRetryableExceptionContract to the class definition and that exception will fail an activity, as well.

@travisaustin This is a really nice suggestion.

I will improve my PR to add that.

@rmcdaniel It would be really nice if you take out sometime to review this PR?

Thanks a lot

@rmcdaniel
Do you think I should close this PR?
Because it's been open for so long now.

I'm going to try to get to it this week. I will also be pushing out a new release. Thank you for your patience!

@BenQoder Hey there, as promised I have merged this, published a new release and I have also updated the documentation at https://laravel-workflow.com/docs/failures-and-recovery/#non-retryable-exceptions

Thanks for your contribution! 🙌

It's cool... 👍🏾

Finally I can stop using my fork and change to the updated version.