From 913ef862fc165325f9e87e75b867ebb3fba5441b Mon Sep 17 00:00:00 2001
From: Richard McDaniel <richard.lee.mcdaniel@gmail.com>
Date: Sun, 23 Mar 2025 02:15:29 +0000
Subject: [PATCH] Improve test coverage

---
 tests/Fixtures/TestThrowOnReturnWorkflow.php  | 20 ++++++++
 .../Fixtures/TestYieldNonPromiseWorkflow.php  | 15 ++++++
 tests/Unit/WorkflowTest.php                   | 51 +++++++++++++++++++
 3 files changed, 86 insertions(+)
 create mode 100644 tests/Fixtures/TestThrowOnReturnWorkflow.php
 create mode 100644 tests/Fixtures/TestYieldNonPromiseWorkflow.php

diff --git a/tests/Fixtures/TestThrowOnReturnWorkflow.php b/tests/Fixtures/TestThrowOnReturnWorkflow.php
new file mode 100644
index 0000000..7ee9360
--- /dev/null
+++ b/tests/Fixtures/TestThrowOnReturnWorkflow.php
@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixtures;
+
+use Workflow\Workflow;
+
+class TestThrowOnReturnWorkflow extends Workflow
+{
+    public function execute()
+    {
+        return new class() {
+            public function valid()
+            {
+                return false;
+            }
+        };
+    }
+}
diff --git a/tests/Fixtures/TestYieldNonPromiseWorkflow.php b/tests/Fixtures/TestYieldNonPromiseWorkflow.php
new file mode 100644
index 0000000..e53a0ba
--- /dev/null
+++ b/tests/Fixtures/TestYieldNonPromiseWorkflow.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixtures;
+
+use Workflow\Workflow;
+
+class TestYieldNonPromiseWorkflow extends Workflow
+{
+    public function execute()
+    {
+        yield 'not-a-promise';
+    }
+}
diff --git a/tests/Unit/WorkflowTest.php b/tests/Unit/WorkflowTest.php
index 04d0998..3f95402 100644
--- a/tests/Unit/WorkflowTest.php
+++ b/tests/Unit/WorkflowTest.php
@@ -4,13 +4,16 @@
 
 namespace Tests\Unit;
 
+use BadMethodCallException;
 use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\Event;
 use Tests\Fixtures\TestActivity;
 use Tests\Fixtures\TestChildWorkflow;
 use Tests\Fixtures\TestOtherActivity;
 use Tests\Fixtures\TestParentWorkflow;
+use Tests\Fixtures\TestThrowOnReturnWorkflow;
 use Tests\Fixtures\TestWorkflow;
+use Tests\Fixtures\TestYieldNonPromiseWorkflow;
 use Tests\TestCase;
 use Workflow\Events\WorkflowFailed;
 use Workflow\Exception;
@@ -276,4 +279,52 @@ public function testParentPending(): void
         $this->assertSame(WorkflowCompletedStatus::class, $childWorkflow->status());
         $this->assertSame('other', $childWorkflow->output());
     }
+
+    public function testThrowsWhenExecuteMethodIsMissing(): void
+    {
+        $stub = WorkflowStub::load(WorkflowStub::make(TestWorkflow::class)->id());
+        $storedWorkflow = StoredWorkflow::findOrFail($stub->id());
+        $storedWorkflow->update([
+            'arguments' => Serializer::serialize([]),
+            'status' => WorkflowPendingStatus::class,
+        ]);
+
+        $this->expectException(BadMethodCallException::class);
+        $this->expectExceptionMessage('Execute method not implemented.');
+
+        $workflow = new Workflow($storedWorkflow);
+        $workflow->handle();
+    }
+
+    public function testThrowsWhenYieldNonPromise(): void
+    {
+        $stub = WorkflowStub::load(WorkflowStub::make(TestYieldNonPromiseWorkflow::class)->id());
+        $storedWorkflow = StoredWorkflow::findOrFail($stub->id());
+        $storedWorkflow->update([
+            'arguments' => Serializer::serialize([]),
+            'status' => WorkflowPendingStatus::class,
+        ]);
+
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('something went wrong');
+
+        $workflow = new TestYieldNonPromiseWorkflow($storedWorkflow);
+        $workflow->handle();
+    }
+
+    public function testThrowsWrappedException(): void
+    {
+        $stub = WorkflowStub::load(WorkflowStub::make(TestThrowOnReturnWorkflow::class)->id());
+        $storedWorkflow = StoredWorkflow::findOrFail($stub->id());
+        $storedWorkflow->update([
+            'arguments' => Serializer::serialize([]),
+            'status' => WorkflowPendingStatus::class,
+        ]);
+
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Workflow failed.');
+
+        $workflow = new TestThrowOnReturnWorkflow($storedWorkflow);
+        $workflow->handle();
+    }
 }

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/laravel-workflow/laravel-workflow/pull/227.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/laravel-workflow/laravel-workflow/pull/227.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/laravel-workflow/laravel-workflow/pull/227.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/laravel-workflow/laravel-workflow/pull/227.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>