Merge pull request confluentinc#33 from confluentinc/destroy_on_close

edenhill · web-flow · commit 3ee33f0ed5d8 · 2016-08-23T20:20:31.000+02:00
Destroy rd_kafka_t handle on consumer.close() (confluentinc#30)
diff --git a/confluent_kafka/src/Consumer.c b/confluent_kafka/src/Consumer.c
@@ -391,12 +391,18 @@ static PyObject *Consumer_poll (Handle *self, PyObject *args,
 
 static PyObject *Consumer_close (Handle *self, PyObject *ignore) {
 	CallState cs;
+	int raise = 0;
 
 	CallState_begin(self, &cs);
 
 	rd_kafka_consumer_close(self->rk);
 
-	if (!CallState_end(self, &cs))
+	raise = !CallState_end(self, &cs);
+
+	rd_kafka_destroy(self->rk);
+	self->rk = NULL;
+
+	if (raise)
 		return NULL;
 
 	Py_RETURN_NONE;
