v-attr should also set property for checked and selected

yyx990803 · yyx990803 · commit 59c9456ea99c · 2015-08-12T12:41:55.000-04:00
diff --git a/src/directives/attr.js b/src/directives/attr.js
@@ -1,6 +1,11 @@
 // xlink
 var xlinkNS = 'http://www.w3.org/1999/xlink'
 var xlinkRE = /^xlink:/
+var inputProps = {
+  value: 1,
+  checked: 1,
+  selected: 1
+}
 
 module.exports = {
 
@@ -35,12 +40,12 @@ module.exports = {
   },
 
   setAttr: function (attr, value) {
-    if (attr === 'value' && attr in this.el) {
+    if (inputProps[attr] && attr in this.el) {
       if (!this.valueRemoved) {
         this.el.removeAttribute(attr)
         this.valueRemoved = true
       }
-      this.el.value = value
+      this.el[attr] = value
     } else if (value != null && value !== false) {
       if (xlinkRE.test(attr)) {
         this.el.setAttributeNS(xlinkNS, attr, value)
diff --git a/test/unit/specs/directives/attr_spec.js b/test/unit/specs/directives/attr_spec.js
@@ -32,6 +32,12 @@ if (_.inBrowser) {
       dir.update('what')
       expect(dir.el.hasAttribute('value')).toBe(false)
       expect(dir.el.value).toBe('what')
+      dir.el = document.createElement('input')
+      dir.el.type = 'checkbox'
+      dir.arg = 'checked'
+      expect(dir.el.checked).toBe(false)
+      dir.update(true)
+      expect(dir.el.checked).toBe(true)
     })
 
     it('xlink', function () {
