pythongh-127146: xfail more Emscripten stack overflows (python#134358)

hoodmane · lkollar · commit 0e4d90e15c58 · 2025-05-26T16:29:43.000+03:00
Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.
diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
@@ -1120,6 +1120,7 @@ def test_filter_pickle(self):
             self.check_iter_pickle(f1, list(f2), proto)
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_filter_dealloc(self):
         # Tests recursive deallocation of nested filter objects using the
diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py
@@ -412,10 +412,12 @@ def test_trashcan_subclass(self):
             L = MyList((L,))
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class1(self):
         self.do_test_trashcan_python_class(list)
 
     @support.requires_resource('cpu')
+    @support.skip_emscripten_stack_overflow()
     def test_trashcan_python_class2(self):
         from _testcapi import MyList
         self.do_test_trashcan_python_class(MyList)
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
@@ -4523,6 +4523,7 @@ class Oops(object):
         del o
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_wrapper_segfault(self):
         # SF 927248: deeply nested wrappers could cause stack overflow
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
@@ -1429,6 +1429,7 @@ def g():
         self.assertIn("maximum recursion depth exceeded", str(exc))
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @cpython_only
     @support.requires_resource('cpu')
     def test_trashcan_recursion(self):
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
@@ -572,7 +572,7 @@ def do_test(test, obj, abilities):
         for [test, abilities] in tests:
             with self.subTest(test):
                 if test == pipe_writer and not threading_helper.can_start_thread:
-                    skipTest()
+                    self.skipTest("Need threads")
                 with test() as obj:
                     do_test(test, obj, abilities)
 
