Add handling of tags in docker-helper #12943
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
Helper Script Tests29 tests 29 ✅ 0s ⏱️ Results for commit 3555f92. ♻️ This comment has been updated with latest results. |
Co-authored-by: Daniel Fangl <daniel.fangl@localstack.cloud>
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 21s ⏱️ Results for commit 3555f92. |
LocalStack Community integration with Pro 2 files 2 suites 1h 41m 24s ⏱️ Results for commit 3555f92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the latest release we still had issues with pushing docker images on pipeline runs triggered by the tag push.
This is because the docker helper assumes that only the
mainbranch should be allowed for pushing the images. Since tags are not bound to a branch, a tag-triggered run will not have a branch ref.We need to add extra provisions for allowing tagged commits to also push images.
/cc @dfangl (and thanks for providing the patch files)
Changes
Testing
To avoid further issues we'll need to do a disarmed action run with pushing enabled.
TODO
What's left to do: