Disable unnecessary zooming and panning in Chart/Log/MarkdownRenderer

64json · 64json · commit 68a1629d6648 · 2018-12-09T00:33:10.000-05:00
diff --git a/src/frontend/core/renderers/Array2DRenderer/index.jsx b/src/frontend/core/renderers/Array2DRenderer/index.jsx
@@ -4,6 +4,13 @@ import styles from './stylesheet.scss';
 import { classes } from '/common/util';
 
 class Array2DRenderer extends Renderer {
+  constructor(props) {
+    super(props);
+
+    this.togglePan(true);
+    this.toggleZoom(true);
+  }
+
   renderData() {
     const { data } = this.props.data;
 
diff --git a/src/frontend/core/renderers/GraphRenderer/index.jsx b/src/frontend/core/renderers/GraphRenderer/index.jsx
@@ -9,6 +9,9 @@ class GraphRenderer extends Renderer {
 
     this.element = React.createRef();
     this.selectedNode = null;
+
+    this.togglePan(true);
+    this.toggleZoom(true);
   }
 
   handleMouseDown(e) {
diff --git a/src/frontend/core/renderers/Renderer/index.jsx b/src/frontend/core/renderers/Renderer/index.jsx
@@ -11,6 +11,12 @@ class Renderer extends React.Component {
     this.handleMouseMove = this.handleMouseMove.bind(this);
     this.handleMouseUp = this.handleMouseUp.bind(this);
     this.handleWheel = this.handleWheel.bind(this);
+
+    this._handleMouseDown = this.handleMouseDown;
+    this._handleWheel = this.handleWheel;
+    this.togglePan(false);
+    this.toggleZoom(false);
+
     this.lastX = null;
     this.lastY = null;
     this.centerX = 0;
@@ -24,6 +30,14 @@ class Renderer extends React.Component {
   componentDidUpdate(prevProps, prevState, snapshot) {
   }
 
+  togglePan(enable = !this.handleMouseDown) {
+    this.handleMouseDown = enable ? this._handleMouseDown : undefined;
+  }
+
+  toggleZoom(enable = !this.handleWheel) {
+    this.handleWheel = enable ? this._handleWheel : undefined;
+  }
+
   handleMouseDown(e) {
     const { clientX, clientY } = e;
     this.lastX = clientX;

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,9 @@ class GraphRenderer extends Renderer {`
`9`	`9`
`10`	`10`	`this.element = React.createRef();`
`11`	`11`	`this.selectedNode = null;`
	`12`	`+`
	`13`	`+ this.togglePan(true);`
	`14`	`+ this.toggleZoom(true);`
`12`	`15`	`}`
`13`	`16`
`14`	`17`	`handleMouseDown(e) {`