Assign CSN for commits with INVALID_CSN during recovery. That can happen due to donor node reboot (and lost map)

kelvich · kelvich · commit cca50ae33219 · 2017-11-13T02:23:41.000+03:00
diff --git a/pglogical_apply.c b/pglogical_apply.c
@@ -739,7 +739,7 @@ process_remote_commit(StringInfo in)
 			Assert(!TransactionIdIsValid(MtmGetCurrentTransactionId()));
 			csn = pq_getmsgint64(in);
 			/*
-			 * Since our recovery method allows undershoot of csn, we can receive
+			 * Since our recovery method allows undershoot of lsn, we can receive
 			 * some already committed transactions. And in case of donor node reboot
 			 * xid<->csn mapping for them will be lost. However we must filter such
 			 * transactions in walreceiver before this code. --sk
@@ -750,7 +750,10 @@ process_remote_commit(StringInfo in)
 			MtmResetTransaction();
 			StartTransactionCommand();
 			MtmBeginSession(origin_node);
-			MtmSetCurrentTransactionCSN(csn);
+			if (csn == INVALID_CSN && Mtm->status == MTM_RECOVERY)
+				MtmSetCurrentTransactionCSN(MtmAssignCSN());
+			else
+				MtmSetCurrentTransactionCSN(csn);
 			MtmSetCurrentTransactionGID(gid);
 			FinishPreparedTransaction(gid, true);
 			MTM_LOG2("Distributed transaction %s is committed", gid);
