Skip to content

Commit f0a648b

Browse files
authored
fix(SSE): only initialize http.Server when not set (#229)
1 parent ffc63d9 commit f0a648b

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

server/sse.go

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,21 @@ func NewTestServer(server *MCPServer, opts ...SSEOption) *httptest.Server {
190190
// It sets up HTTP handlers for SSE and message endpoints.
191191
func (s *SSEServer) Start(addr string) error {
192192
s.mu.Lock()
193-
s.srv = &http.Server{
194-
Addr: addr,
195-
Handler: s,
196-
}
197-
s.mu.Unlock()
193+
defer s.mu.Unlock()
198194

195+
if s.srv == nil {
196+
s.srv = &http.Server{
197+
Addr: addr,
198+
Handler: s,
199+
}
200+
} else {
201+
if s.srv.Addr == "" {
202+
s.srv.Addr = addr
203+
} else if s.srv.Addr != addr {
204+
return fmt.Errorf("conflicting listen address: WithHTTPServer(%q) vs Start(%q)", s.srv.Addr, addr)
205+
}
206+
}
207+
199208
return s.srv.ListenAndServe()
200209
}
201210

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy