Skip to content

Commit 78bcd91

Browse files
authored
Merge pull request #24117 from meeseeksmachine/auto-backport-of-pr-24113-on-v3.6.x
Backport PR #24113 on branch v3.6.x (Add exception class to pytest.warns calls)
2 parents d336a67 + 305a146 commit 78bcd91

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/matplotlib/tests/test_axes.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,13 +491,15 @@ def test_subclass_clear_cla():
491491
# Note, we cannot use mocking here as we want to be sure that the
492492
# superclass fallback does not recurse.
493493

494-
with pytest.warns(match='Overriding `Axes.cla`'):
494+
with pytest.warns(PendingDeprecationWarning,
495+
match='Overriding `Axes.cla`'):
495496
class ClaAxes(Axes):
496497
def cla(self):
497498
nonlocal called
498499
called = True
499500

500-
with pytest.warns(match='Overriding `Axes.cla`'):
501+
with pytest.warns(PendingDeprecationWarning,
502+
match='Overriding `Axes.cla`'):
501503
class ClaSuperAxes(Axes):
502504
def cla(self):
503505
nonlocal called

lib/matplotlib/tests/test_colors.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def test_double_register_builtin_cmap():
117117
mpl.colormaps[name], name=name, force=True
118118
)
119119
with pytest.raises(ValueError, match='A colormap named "viridis"'):
120-
with pytest.warns():
120+
with pytest.warns(PendingDeprecationWarning):
121121
cm.register_cmap(name, mpl.colormaps[name])
122122
with pytest.warns(UserWarning):
123123
# TODO is warning more than once!
@@ -128,7 +128,7 @@ def test_unregister_builtin_cmap():
128128
name = "viridis"
129129
match = f'cannot unregister {name!r} which is a builtin colormap.'
130130
with pytest.raises(ValueError, match=match):
131-
with pytest.warns():
131+
with pytest.warns(PendingDeprecationWarning):
132132
cm.unregister_cmap(name)
133133

134134

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy