fix(comment): #29325 (comment)

cmp0xff · cmp0xff · commit b337f945dfb2 · 2024-12-21T00:13:47.000+01:00
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -4596,7 +4596,7 @@ def _make_twin_axes(self, *args, **kwargs):
         self._twinned_axes.join(self, twin)
         return twin
 
-    def twinx(self, **kwargs):
+    def twinx(self, axes_class=None, **kwargs):
         """
         Create a twin Axes sharing the xaxis.
 
@@ -4608,6 +4608,11 @@ def twinx(self, **kwargs):
 
         Parameters
         ----------
+        axes_class : subclass type of `~.axes.Axes`, optional
+            The `.axes.Axes` subclass that is instantiated.  This parameter
+            is incompatible with *projection* and *polar*.  See
+            :ref:`axisartist_users-guide-index` for examples.
+
         kwargs : dict
             The keyword arguments passed to ``add_subplot()`` or ``add_axes()``.
 
@@ -4621,9 +4626,9 @@ def twinx(self, **kwargs):
         For those who are 'picking' artists while using twinx, pick
         events are only called for the artists in the top-most Axes.
         """
-        if not {"projection", "polar", "axes_class"}.intersection(kwargs):
-            kwargs["axes_class"] = type(self)
-        ax2 = self._make_twin_axes(sharex=self, axes_class=type(self), **kwargs)
+        if axes_class:
+            kwargs["axes_class"] = axes_class
+        ax2 = self._make_twin_axes(sharex=self, **kwargs)
         ax2.yaxis.tick_right()
         ax2.yaxis.set_label_position('right')
         ax2.yaxis.set_offset_position('right')
@@ -4634,7 +4639,7 @@ def twinx(self, **kwargs):
         ax2.xaxis.units = self.xaxis.units
         return ax2
 
-    def twiny(self, **kwargs):
+    def twiny(self, axes_class=None, **kwargs):
         """
         Create a twin Axes sharing the yaxis.
 
@@ -4646,6 +4651,11 @@ def twiny(self, **kwargs):
 
         Parameters
         ----------
+        axes_class : subclass type of `~.axes.Axes`, optional
+            The `.axes.Axes` subclass that is instantiated.  This parameter
+            is incompatible with *projection* and *polar*.  See
+            :ref:`axisartist_users-guide-index` for examples.
+
         kwargs : dict
             The keyword arguments passed to ``add_subplot()`` or ``add_axes()``.
 
@@ -4659,9 +4669,9 @@ def twiny(self, **kwargs):
         For those who are 'picking' artists while using twiny, pick
         events are only called for the artists in the top-most Axes.
         """
-        if not {"projection", "polar", "axes_class"}.intersection(kwargs):
-            kwargs["axes_class"] = type(self)
-        ax2 = self._make_twin_axes(sharey=self, axes_class=type(self), **kwargs)
+        if axes_class:
+            kwargs["axes_class"] = axes_class
+        ax2 = self._make_twin_axes(sharey=self, **kwargs)
         ax2.xaxis.tick_top()
         ax2.xaxis.set_label_position('top')
         ax2.set_autoscaley_on(self.get_autoscaley_on())
diff --git a/lib/matplotlib/axes/_base.pyi b/lib/matplotlib/axes/_base.pyi
@@ -4,6 +4,7 @@ import datetime
 from collections.abc import Callable, Iterable, Iterator, Sequence
 from matplotlib import cbook
 from matplotlib.artist import Artist
+from matplotlib.axes import Axes
 from matplotlib.axis import XAxis, YAxis, Tick
 from matplotlib.backend_bases import RendererBase, MouseButton, MouseEvent
 from matplotlib.cbook import CallbackRegistry
@@ -28,7 +29,6 @@ import numpy as np
 from numpy.typing import ArrayLike
 from typing import Any, Literal, TypeVar, overload
 from matplotlib.typing import ColorType
-from typing_extensions import Self
 
 _T = TypeVar("_T", bound=Artist)
 
@@ -385,8 +385,8 @@ class _AxesBase(martist.Artist):
         bbox_extra_artists: Sequence[Artist] | None = ...,
         for_layout_only: bool = ...
     ) -> Bbox | None: ...
-    def twinx(self, **kwargs) -> Self: ...
-    def twiny(self, **kwargs) -> Self: ...
+    def twinx(self, axes_class: Axes | None = ..., **kwargs) -> Axes: ...
+    def twiny(self, axes_class: Axes | None = ..., **kwargs) -> Axes: ...
     def get_shared_x_axes(self) -> cbook.GrouperView: ...
     def get_shared_y_axes(self) -> cbook.GrouperView: ...
     def label_outer(self, remove_inner_ticks: bool = ...) -> None: ...
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -7548,7 +7548,7 @@ def test_twinx_subclass(axes_class, kw0, kw1):
     for k, v in kw0.items():
         assert getattr(classed_ax, k) == v
 
-    twin = classed_ax.twinx(**kw1)
+    twin = classed_ax.twinx(axes_class=axes_class, **kw1)
     assert type(twin) is axes_class
     for k, v in kw1.items():
         assert getattr(twin, k) == v
