MNT: Restore auto-adding Axes3D to their parent figure on init

tacaswell · tacaswell · commit d96fa5516d22 · 2021-02-11T00:30:24.000-05:00
Only do this when directly created by the user, not via our machinery.
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -1517,7 +1517,9 @@ def _process_projection_requirements(
                 raise TypeError(
                     f"projection must be a string, None or implement a "
                     f"_as_mpl_axes method, not {projection!r}")
-
+        if projection_class.__name__ == 'Axes3D':
+            print(f'{projection_class=}')
+            kwargs['__internal'] = True
         return projection_class, kwargs
 
     def get_default_bbox_extra_artists(self):
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -96,10 +96,11 @@ def __init__(
         if sharez is not None:
             self._shared_z_axes.join(self, sharez)
             self._adjustable = 'datalim'
-
+        internal_call = kwargs.pop('__internal', False)
         super().__init__(
             fig, rect, frameon=True, box_aspect=box_aspect, *args, **kwargs
         )
+
         # Disable drawing of axes by base class
         super().set_axis_off()
         # Enable drawing of axes by Axes3D class
@@ -128,6 +129,8 @@ def __init__(
         # mplot3d currently manages its own spines and needs these turned off
         # for bounding box calculations
         self.spines[:].set_visible(False)
+        if not internal_call:
+            fig.add_axes(self)
 
     def set_axis_off(self):
         self._axis3don = False
