FIX: make bar work with timedeltas

jklymak · jklymak · commit df6e97628d06 · 2018-11-28T10:53:18.000-08:00
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -2063,6 +2063,20 @@ def step(self, x, y, *args, where='pre', **kwargs):
         kwargs['drawstyle'] = 'steps-' + where
         return self.plot(x, y, *args, **kwargs)
 
+    @staticmethod
+    def _convert_dx(x0, x, dx, convert):
+        """ Small helper to do logic of width conversion flexibly """
+        print(x0, x, dx, convert)
+        try:
+            # attempt to add the width to x0; this works for
+            # datetime+timedelta, for instance
+            dx = convert(x0 + dx) - x
+        except (TypeError, AttributeError):
+            # but doesn't work for 'string' + float, so just
+            # see if the converter works on the float.
+            dx = convert(dx)
+        return dx
+
     @_preprocess_data(replace_names=["x", "left",
                                      "height", "width",
                                      "y", "bottom",
@@ -2232,23 +2246,25 @@ def bar(self, x, height, width=0.8, bottom=None, *, align="center",
         else:
             raise ValueError('invalid orientation: %s' % orientation)
 
+        x, height, width, y, linewidth = np.broadcast_arrays(
+            # Make args iterable too.
+            np.atleast_1d(x), height, width, y, linewidth)
+
         # lets do some conversions now since some types cannot be
         # subtracted uniformly
         if self.xaxis is not None:
+            x0 = x
             x = self.convert_xunits(x)
-            width = self.convert_xunits(width)
+            width = self._convert_dx(x0, x, width, self.convert_xunits)
             if xerr is not None:
-                xerr = self.convert_xunits(xerr)
+                xerr = self._convert_dx(x0, x, xerr, self.convert_xunits)
 
         if self.yaxis is not None:
+            y0 = y
             y = self.convert_yunits(y)
-            height = self.convert_yunits(height)
+            height = self._convert_dx(y0, y, height, self.convert_yunits)
             if yerr is not None:
-                yerr = self.convert_yunits(yerr)
-
-        x, height, width, y, linewidth = np.broadcast_arrays(
-            # Make args iterable too.
-            np.atleast_1d(x), height, width, y, linewidth)
+                yerr = self._convert_dx(y0, y, yerr, self.convert_yunits)
 
         # Now that units have been converted, set the tick locations.
         if orientation == 'vertical':
