From 24d18371c7754e8161fe73b64dc9cdf695573ec9 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Sat, 10 Aug 2019 19:21:35 +0100 Subject: [PATCH] Correct set formatters and locators on removed shared axis --- lib/matplotlib/figure.py | 34 +++++++++++++++++++---------- lib/matplotlib/tests/test_figure.py | 7 ++++++ 2 files changed, 30 insertions(+), 11 deletions(-) diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py index 4e60d82a136f..8d2c475252c2 100644 --- a/lib/matplotlib/figure.py +++ b/lib/matplotlib/figure.py @@ -1596,25 +1596,37 @@ def subplots(self, nrows=1, ncols=1, sharex=False, sharey=False, return axarr def _remove_ax(self, ax): - def _reset_loc_form(axis): + def _reset_locators_and_formatters(axis): # Set the formatters and locators to be associated with axis # (where previously they may have been associated with another # Axis isntance) + # + # Because set_major_formatter() etc. force isDefault_* to be False, + # we have to manually check if the original formatter was a + # default and manually set isDefault_* if that was the case. majfmt = axis.get_major_formatter() - if not majfmt.axis.isDefault_majfmt: - axis.set_major_formatter(majfmt) + isDefault = majfmt.axis.isDefault_majfmt + axis.set_major_formatter(majfmt) + if isDefault: + majfmt.axis.isDefault_majfmt = True majloc = axis.get_major_locator() - if not majloc.axis.isDefault_majloc: - axis.set_major_locator(majloc) + isDefault = majloc.axis.isDefault_majloc + axis.set_major_locator(majloc) + if isDefault: + majloc.axis.isDefault_majloc = True minfmt = axis.get_minor_formatter() - if not minfmt.axis.isDefault_minfmt: - axis.set_minor_formatter(minfmt) + isDefault = majloc.axis.isDefault_minfmt + axis.set_minor_formatter(minfmt) + if isDefault: + minfmt.axis.isDefault_minfmt = True minloc = axis.get_minor_locator() - if not minfmt.axis.isDefault_minloc: - axis.set_minor_locator(minloc) + isDefault = majloc.axis.isDefault_minloc + axis.set_minor_locator(minloc) + if isDefault: + minloc.axis.isDefault_minloc = True def _break_share_link(ax, grouper): siblings = grouper.get_siblings(ax) @@ -1628,11 +1640,11 @@ def _break_share_link(ax, grouper): self.delaxes(ax) last_ax = _break_share_link(ax, ax._shared_y_axes) if last_ax is not None: - _reset_loc_form(last_ax.yaxis) + _reset_locators_and_formatters(last_ax.yaxis) last_ax = _break_share_link(ax, ax._shared_x_axes) if last_ax is not None: - _reset_loc_form(last_ax.xaxis) + _reset_locators_and_formatters(last_ax.xaxis) def clf(self, keep_observers=False): """ diff --git a/lib/matplotlib/tests/test_figure.py b/lib/matplotlib/tests/test_figure.py index 4390df6af4a7..a9e8dfade9dc 100644 --- a/lib/matplotlib/tests/test_figure.py +++ b/lib/matplotlib/tests/test_figure.py @@ -480,3 +480,10 @@ def test_axes_removal(): axs[0].plot([datetime(2000, 1, 1), datetime(2000, 2, 1)], [0, 1]) assert isinstance(axs[0].xaxis.get_major_formatter(), ScalarFormatter) + + +def test_removed_axis(): + # Simple smoke test to make sure removing a shared axis works + fig, axs = plt.subplots(2, sharex=True) + axs[0].remove() + fig.canvas.draw() pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy