From df5648d8aab07f7a08b2df727b6cb98fd8c90b8a Mon Sep 17 00:00:00 2001 From: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Date: Thu, 8 Sep 2022 23:31:05 +0200 Subject: [PATCH] Revert "Refactor handling of tick and ticklabel visiblity in Axis.clear()" This reverts commit 2357c92d87d96d519c8470776e76180e71663d0b. --- lib/matplotlib/axis.py | 36 ++++++++---------------------------- 1 file changed, 8 insertions(+), 28 deletions(-) diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py index 1ee97dc9078b..2f5dd6dcc0ea 100644 --- a/lib/matplotlib/axis.py +++ b/lib/matplotlib/axis.py @@ -846,36 +846,14 @@ def get_children(self): return [self.label, self.offsetText, *self.get_major_ticks(), *self.get_minor_ticks()] - def _reset_major_tick_kw(self, keep_tick_and_label_visibility=False): - """ - Reset major tick params to defaults. - - Shared subplots pre-configure tick and label visibility. To keep this - beyond an Axis.clear() operation, we may - *keep_tick_and_label_visibility*. - """ - backup = {name: value for name, value in self._major_tick_kw.items() - if name in ['tick1On', 'tick2On', 'label1On', 'label2On']} + def _reset_major_tick_kw(self): self._major_tick_kw.clear() - if keep_tick_and_label_visibility: - self._major_tick_kw.update(backup) self._major_tick_kw['gridOn'] = ( mpl.rcParams['axes.grid'] and mpl.rcParams['axes.grid.which'] in ('both', 'major')) - def _reset_minor_tick_kw(self, keep_tick_and_label_visibility=False): - """ - Reset minor tick params to defaults. - - Shared subplots pre-configure tick and label visibility. To keep this - beyond an Axis.clear() operation, we may - *keep_tick_and_label_visibility*. - """ - backup = {name: value for name, value in self._minor_tick_kw.items() - if name in ['tick1On', 'tick2On', 'label1On', 'label2On']} + def _reset_minor_tick_kw(self): self._minor_tick_kw.clear() - if keep_tick_and_label_visibility: - self._minor_tick_kw.update(backup) self._minor_tick_kw['gridOn'] = ( mpl.rcParams['axes.grid'] and mpl.rcParams['axes.grid.which'] in ('both', 'minor')) @@ -892,8 +870,6 @@ def clear(self): - major and minor grid - units - registered callbacks - - This does not reset tick and tick label visibility. """ self.label._reset_visual_defaults() self.offsetText._reset_visual_defaults() @@ -908,8 +884,12 @@ def clear(self): signals=["units", "units finalize"]) # whether the grids are on - self._reset_major_tick_kw(keep_tick_and_label_visibility=True) - self._reset_minor_tick_kw(keep_tick_and_label_visibility=True) + self._major_tick_kw['gridOn'] = ( + mpl.rcParams['axes.grid'] and + mpl.rcParams['axes.grid.which'] in ('both', 'major')) + self._minor_tick_kw['gridOn'] = ( + mpl.rcParams['axes.grid'] and + mpl.rcParams['axes.grid.which'] in ('both', 'minor')) self.reset_ticks() self.converter = None pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy