Skip to content

Commit 9eb43ee

Browse files
committed
Fix tests
1 parent b73bf6f commit 9eb43ee

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/napari_matplotlib/slice.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,22 @@ def on_update_layers(self) -> None:
5858
"""
5959
Called when layer selection is updated.
6060
"""
61+
if not len(self.layers):
62+
return
6163
if self.current_dim_name == "x":
6264
max = self._layer.data.shape[-2]
6365
elif self.current_dim_name == "y":
6466
max = self._layer.data.shape[-1]
6567
else:
6668
raise RuntimeError("dim name must be x or y")
67-
self.slice_selector.setRange(0, max)
69+
self.slice_selector.setRange(0, max - 1)
6870

6971
@property
7072
def _slice_width(self) -> int:
7173
"""
7274
Width of the slice being plotted.
7375
"""
74-
return self._layer.data.shape[self.current_dim_index] - 1
76+
return self._layer.data.shape[self.current_dim_index]
7577

7678
@property
7779
def _layer(self) -> napari.layers.Layer:

src/napari_matplotlib/tests/test_slice.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,6 @@ def test_slice_axes(make_napari_viewer, astronaut_data):
5858
assert widget.current_dim_name == "x"
5959
assert widget.slice_selector.value() == 0
6060
assert widget.slice_selector.minimum() == 0
61-
assert widget.slice_selector.maximum() == data.shape[0]
61+
assert widget.slice_selector.maximum() == data.shape[0] - 1
6262
# x/y are flipped in napari
6363
assert widget._slice_width == data.shape[1]

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy