ci: Always call apt-get update before apt-get install.

jepler · jepler · commit 02ff49bf7445 · 2025-07-10T19:49:21.000+01:00
I saw a recent build failure in build_renesas_ra_board. It appears to be the case that a security update for this package was recently issued by ubuntu for CVE-2025-4565 and the buggy version is no longer on package servers. However, it is still referred to by the cached apt metadata in the GitHub runners. I added apt-get update there, and audited for other sites in ci.sh where it might be necessary. Signed-off-by: Jeff Epler <jepler@gmail.com>
diff --git a/tools/ci.sh b/tools/ci.sh
@@ -13,11 +13,13 @@ ulimit -n 1024
 # general helper functions
 
 function ci_gcc_arm_setup {
+    sudo apt-get update
     sudo apt-get install gcc-arm-none-eabi libnewlib-arm-none-eabi
     arm-none-eabi-gcc --version
 }
 
 function ci_gcc_riscv_setup {
+    sudo apt-get update
     sudo apt-get install gcc-riscv64-unknown-elf picolibc-riscv64-unknown-elf
     riscv64-unknown-elf-gcc --version
 }
@@ -45,6 +47,7 @@ function ci_picotool_setup {
 # c code formatting
 
 function ci_c_code_formatting_setup {
+    sudo apt-get update
     sudo apt-get install uncrustify
     uncrustify --version
 }
@@ -723,6 +726,7 @@ function ci_unix_float_run_tests {
 }
 
 function ci_unix_clang_setup {
+    sudo apt-get update
     sudo apt-get install clang
     clang --version
 }
@@ -862,6 +866,7 @@ function ci_unix_qemu_riscv64_run_tests {
 # ports/windows
 
 function ci_windows_setup {
+    sudo apt-get update
     sudo apt-get install gcc-mingw-w64
 }
 

Original file line number	Diff line number	Diff line change
`@@ -13,11 +13,13 @@ ulimit -n 1024`
`13`	`13`	`# general helper functions`
`14`	`14`
`15`	`15`	`function ci_gcc_arm_setup {`
	`16`	`+ sudo apt-get update`
`16`	`17`	`sudo apt-get install gcc-arm-none-eabi libnewlib-arm-none-eabi`
`17`	`18`	`arm-none-eabi-gcc --version`
`18`	`19`	`}`
`19`	`20`
`20`	`21`	`function ci_gcc_riscv_setup {`
	`22`	`+ sudo apt-get update`
`21`	`23`	`sudo apt-get install gcc-riscv64-unknown-elf picolibc-riscv64-unknown-elf`
`22`	`24`	`riscv64-unknown-elf-gcc --version`
`23`	`25`	`}`
`@@ -45,6 +47,7 @@ function ci_picotool_setup {`
`45`	`47`	`# c code formatting`
`46`	`48`
`47`	`49`	`function ci_c_code_formatting_setup {`
	`50`	`+ sudo apt-get update`
`48`	`51`	`sudo apt-get install uncrustify`
`49`	`52`	`uncrustify --version`
`50`	`53`	`}`
`@@ -723,6 +726,7 @@ function ci_unix_float_run_tests {`
`723`	`726`	`}`
`724`	`727`
`725`	`728`	`function ci_unix_clang_setup {`
	`729`	`+ sudo apt-get update`
`726`	`730`	`sudo apt-get install clang`
`727`	`731`	`clang --version`
`728`	`732`	`}`
`@@ -862,6 +866,7 @@ function ci_unix_qemu_riscv64_run_tests {`
`862`	`866`	`# ports/windows`
`863`	`867`
`864`	`868`	`function ci_windows_setup {`
	`869`	`+ sudo apt-get update`
`865`	`870`	`sudo apt-get install gcc-mingw-w64`
`866`	`871`	`}`
`867`	`872`