esp32/machine_timer: Fix timer.value() for an uninitialized timer.

robert-hh · dpgeorge · commit 1d4bf8ac4023 · 2025-05-14T11:58:36.000+10:00
Raises a value error in that case, which happens after a timer was created but not initialized, or after calling `timer.deinit()`. Fixes issue #17033. Signed-off-by: robert-hh <robert@hammelrath.com>
diff --git a/ports/esp32/machine_timer.c b/ports/esp32/machine_timer.c
@@ -246,6 +246,9 @@ static MP_DEFINE_CONST_FUN_OBJ_KW(machine_timer_init_obj, 1, machine_timer_init)
 
 static mp_obj_t machine_timer_value(mp_obj_t self_in) {
     machine_timer_obj_t *self = self_in;
+    if (self->handle == NULL) {
+        mp_raise_ValueError(MP_ERROR_TEXT("timer not set"));
+    }
     uint64_t result = timer_ll_get_counter_value(self->hal_context.dev, self->index);
     return MP_OBJ_NEW_SMALL_INT((mp_uint_t)(result / (TIMER_SCALE / 1000))); // value in ms
 }

Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,9 @@ static MP_DEFINE_CONST_FUN_OBJ_KW(machine_timer_init_obj, 1, machine_timer_init)`
`246`	`246`
`247`	`247`	`static mp_obj_t machine_timer_value(mp_obj_t self_in) {`
`248`	`248`	`machine_timer_obj_t *self = self_in;`
	`249`	`+ if (self->handle == NULL) {`
	`250`	`+ mp_raise_ValueError(MP_ERROR_TEXT("timer not set"));`
	`251`	`+ }`
`249`	`252`	`uint64_t result = timer_ll_get_counter_value(self->hal_context.dev, self->index);`
`250`	`253`	`return MP_OBJ_NEW_SMALL_INT((mp_uint_t)(result / (TIMER_SCALE / 1000))); // value in ms`
`251`	`254`	`}`