esp32/modsocket: add note about ECONNRESET vs. ECONNREFUSED

tve · tve · commit 4830774d6073 · 2020-03-29T20:32:27.000-07:00
diff --git a/ports/esp32/modsocket.c b/ports/esp32/modsocket.c
@@ -376,6 +376,9 @@ STATIC mp_obj_t socket_connect(const mp_obj_t arg0, const mp_obj_t arg1) {
     MP_THREAD_GIL_ENTER();
     lwip_freeaddrinfo(res);
     if (r != 0) {
+        // side-note: LwIP internally doesn't seem to have an error code for ECONNREFUSED and
+        // so refused connections show up as ECONNRESET. Could be band-aided for blocking connect,
+        // harder to do for nonblocking.
         exception_from_errno(errno);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -376,6 +376,9 @@ STATIC mp_obj_t socket_connect(const mp_obj_t arg0, const mp_obj_t arg1) {`
`376`	`376`	`MP_THREAD_GIL_ENTER();`
`377`	`377`	`lwip_freeaddrinfo(res);`
`378`	`378`	`if (r != 0) {`
	`379`	`+ // side-note: LwIP internally doesn't seem to have an error code for ECONNREFUSED and`
	`380`	`+ // so refused connections show up as ECONNRESET. Could be band-aided for blocking connect,`
	`381`	`+ // harder to do for nonblocking.`
`379`	`382`	`exception_from_errno(errno);`
`380`	`383`	`}`
`381`	`384`