ports/renesas: Replace MICROPY_EVENT_POLL_HOOK with mp_event_wait.

pi-anl · pi-anl · commit 7dc619998a47 · 2025-04-23T14:28:12.000+10:00
Signed-off-by: Andrew Leech &lt;andrew@alelec.net&gt;
diff --git a/ports/renesas-ra/machine_uart.c b/ports/renesas-ra/machine_uart.c
@@ -501,7 +501,7 @@ static mp_uint_t mp_machine_uart_ioctl(mp_obj_t self_in, mp_uint_t request, uint
             if (!uart_tx_busy(self)) {
                 return 0;
             }
-            MICROPY_EVENT_POLL_HOOK
+            mp_event_wait_indefinite();
         } while (mp_hal_ticks_ms() < timeout);
         *errcode = MP_ETIMEDOUT;
         ret = MP_STREAM_ERROR;
diff --git a/ports/renesas-ra/mpconfigport.h b/ports/renesas-ra/mpconfigport.h
@@ -251,28 +251,17 @@ typedef unsigned int mp_uint_t; // must be pointer size
 typedef long mp_off_t;
 
 #if MICROPY_PY_THREAD
-#define MICROPY_EVENT_POLL_HOOK \
+#define MICROPY_INTERNAL_EVENT_HOOK \
     do { \
-        extern void mp_handle_pending(bool); \
-        mp_handle_pending(true); \
         if (pyb_thread_enabled) { \
             MP_THREAD_GIL_EXIT(); \
             pyb_thread_yield(); \
             MP_THREAD_GIL_ENTER(); \
-        } else { \
-            __WFI(); \
         } \
     } while (0);
 
 #define MICROPY_THREAD_YIELD() pyb_thread_yield()
 #else
-#define MICROPY_EVENT_POLL_HOOK \
-    do { \
-        extern void mp_handle_pending(bool); \
-        mp_handle_pending(true); \
-        __WFI(); \
-    } while (0);
-
 #define MICROPY_THREAD_YIELD()
 #endif
 
diff --git a/ports/renesas-ra/mphalport.c b/ports/renesas-ra/mphalport.c
@@ -104,7 +104,7 @@ int mp_hal_stdin_rx_chr(void) {
             return dupterm_c;
         }
         #endif
-        MICROPY_EVENT_POLL_HOOK
+        mp_event_wait_indefinite();
     }
 }
 
diff --git a/ports/renesas-ra/mphalport.h b/ports/renesas-ra/mphalport.h
@@ -35,6 +35,22 @@
 #define MICROPY_PY_PENDSV_ENTER   uint32_t atomic_state = raise_irq_pri(IRQ_PRI_PENDSV)
 #define MICROPY_PY_PENDSV_EXIT    restore_irq_pri(atomic_state)
 
+
+// Port level Wait-for-Event macro
+//
+// Do not use this macro directly, include py/runtime.h and
+// call mp_event_wait_indefinite() or mp_event_wait_ms(timeout)
+// Uses WFI when timeout is given so it wakes up from systick
+// otherwise it may not wake up within given timeout.
+#define MICROPY_INTERNAL_WFE(TIMEOUT_MS)                        \
+    do {                                                        \
+        if ((TIMEOUT_MS) < 0) {                                 \
+            __WFE();                                            \
+        } else {                                                \
+            __WFI();                                            \
+        }                                                       \
+    } while (0)
+
 #define MICROPY_PY_LWIP_ENTER
 #define MICROPY_PY_LWIP_REENTER
 #define MICROPY_PY_LWIP_EXIT
diff --git a/ports/renesas-ra/systick.c b/ports/renesas-ra/systick.c
@@ -97,22 +97,24 @@ void HAL_Delay(uint32_t Delay) {
 
 // Core delay function that does an efficient sleep and may switch thread context.
 // If IRQs are enabled then we must have the GIL.
-void mp_hal_delay_ms(mp_uint_t Delay) {
+void mp_hal_delay_ms(mp_uint_t ms) {
     if (query_irq() == IRQ_STATE_ENABLED) {
         // IRQs enabled, so can use systick counter to do the delay
         uint32_t start = uwTick;
+        mp_uint_t elapsed = 0;
         // Wraparound of tick is taken care of by 2's complement arithmetic.
         do {
             // This macro will execute the necessary idle behaviour.  It may
             // raise an exception, switch threads or enter sleep mode (waiting for
             // (at least) the SysTick interrupt).
-            MICROPY_EVENT_POLL_HOOK
-        } while (uwTick - start < Delay);
+            mp_event_wait_ms(ms - elapsed);
+            elapsed = uwTick - start;
+        } while (elapsed < ms);
     } else {
         // IRQs disabled, so need to use a busy loop for the delay.
         // To prevent possible overflow of the counter we use a double loop.
         volatile uint32_t count_1ms;
-        while (Delay-- > 0) {
+        while (ms-- > 0) {
             count_1ms = (MICROPY_HW_MCU_PCLK / 1000 / 10);
             while (count_1ms-- > 0) {
                 __asm__ __volatile__ ("nop");
diff --git a/ports/renesas-ra/uart.c b/ports/renesas-ra/uart.c
@@ -477,7 +477,7 @@ bool uart_rx_wait(machine_uart_obj_t *self, uint32_t timeout) {
         if (HAL_GetTick() - start >= timeout) {
             return false; // timeout
         }
-        MICROPY_EVENT_POLL_HOOK
+        mp_event_wait_ms(1);
     }
 }
 
@@ -498,7 +498,7 @@ bool uart_tx_wait(machine_uart_obj_t *self, uint32_t timeout) {
         if (HAL_GetTick() - start >= timeout) {
             return false; // timeout
         }
-        MICROPY_EVENT_POLL_HOOK
+        mp_event_wait_ms(1);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -501,7 +501,7 @@ static mp_uint_t mp_machine_uart_ioctl(mp_obj_t self_in, mp_uint_t request, uint`
`501`	`501`	`if (!uart_tx_busy(self)) {`
`502`	`502`	`return 0;`
`503`	`503`	`}`
`504`		`- MICROPY_EVENT_POLL_HOOK`
	`504`	`+ mp_event_wait_indefinite();`
`505`	`505`	`} while (mp_hal_ticks_ms() < timeout);`
`506`	`506`	`*errcode = MP_ETIMEDOUT;`
`507`	`507`	`ret = MP_STREAM_ERROR;`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ int mp_hal_stdin_rx_chr(void) {`
`104`	`104`	`return dupterm_c;`
`105`	`105`	`}`
`106`	`106`	`#endif`
`107`		`- MICROPY_EVENT_POLL_HOOK`
	`107`	`+ mp_event_wait_indefinite();`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`
Original file line number	Diff line number	Diff line change
`@@ -477,7 +477,7 @@ bool uart_rx_wait(machine_uart_obj_t *self, uint32_t timeout) {`
`477`	`477`	`if (HAL_GetTick() - start >= timeout) {`
`478`	`478`	`return false; // timeout`
`479`	`479`	`}`
`480`		`- MICROPY_EVENT_POLL_HOOK`
	`480`	`+ mp_event_wait_ms(1);`
`481`	`481`	`}`
`482`	`482`	`}`
`483`	`483`
`@@ -498,7 +498,7 @@ bool uart_tx_wait(machine_uart_obj_t *self, uint32_t timeout) {`
`498`	`498`	`if (HAL_GetTick() - start >= timeout) {`
`499`	`499`	`return false; // timeout`
`500`	`500`	`}`
`501`		`- MICROPY_EVENT_POLL_HOOK`
	`501`	`+ mp_event_wait_ms(1);`
`502`	`502`	`}`
`503`	`503`	`}`
`504`	`504`