Skip to content

Commit 8f4a6d5

Browse files
committed
windows/msvc/paths.props: Dont add variant path for mpy-cross build.
This file is shared by mpy-cross.vcxproj, where PyVariant will be not set (because common.props explicitly doesn't set it when building mpy-cross). However, paths.props will attempt to default PyVariantDir to `variants\$(PyVariant)\` which will end up as `variants\\` and the double backslash breaks the cl.exe command line. So this also ensures that PyVariant is set before defaulting PyVariantDir. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
1 parent d080d42 commit 8f4a6d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ports/windows/msvc/paths.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<PyBaseDir>$([System.IO.Path]::GetFullPath(`$(MSBuildThisFileDirectory)..\..\..`))\</PyBaseDir>
2929
<PyWinDir>$(PyBaseDir)ports\windows\</PyWinDir>
3030
<PyBuildDir Condition="'$(PyBuildDir)' == ''">$(PyWinDir)$(PyBuild)\</PyBuildDir>
31-
<PyVariantDir Condition="'$(PyVariantDir)' == ''">$(PyWinDir)variants\$(PyVariant)\</PyVariantDir>
31+
<PyVariantDir Condition="'$(PyVariantDir)' == '' and '$(PyVariant)' != ''">$(PyWinDir)variants\$(PyVariant)\</PyVariantDir>
3232
<PyTargetDir Condition="'$(PyTargetDir)' == ''">$(PyBuildDir)</PyTargetDir>
3333

3434
<!-- All include directories needed for uPy -->

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy