esp32/machine_sdcard: Fix invalid result of SDCard.read/writeblocks.

projectgus · dpgeorge · commit b675c87992b8 · 2025-02-12T13:28:28.000+11:00
Functions would return NULL instead of `mp_const_false` if failed to init.

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton &lt;angus@redyak.com.au&gt;
diff --git a/ports/esp32/machine_sdcard.c b/ports/esp32/machine_sdcard.c
@@ -364,7 +364,7 @@ static mp_obj_t machine_sdcard_readblocks(mp_obj_t self_in, mp_obj_t block_num,
 
     err = sdcard_ensure_card_init((sdcard_card_obj_t *)self, false);
     if (err != ESP_OK) {
-        return false;
+        return mp_const_false;
     }
 
     mp_get_buffer_raise(buf, &bufinfo, MP_BUFFER_WRITE);
@@ -381,7 +381,7 @@ static mp_obj_t machine_sdcard_writeblocks(mp_obj_t self_in, mp_obj_t block_num,
 
     err = sdcard_ensure_card_init((sdcard_card_obj_t *)self, false);
     if (err != ESP_OK) {
-        return false;
+        return mp_const_false;
     }
 
     mp_get_buffer_raise(buf, &bufinfo, MP_BUFFER_READ);

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ static mp_obj_t machine_sdcard_readblocks(mp_obj_t self_in, mp_obj_t block_num,`
`364`	`364`
`365`	`365`	`err = sdcard_ensure_card_init((sdcard_card_obj_t *)self, false);`
`366`	`366`	`if (err != ESP_OK) {`
`367`		`- return false;`
	`367`	`+ return mp_const_false;`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`mp_get_buffer_raise(buf, &bufinfo, MP_BUFFER_WRITE);`
`@@ -381,7 +381,7 @@ static mp_obj_t machine_sdcard_writeblocks(mp_obj_t self_in, mp_obj_t block_num,`
`381`	`381`
`382`	`382`	`err = sdcard_ensure_card_init((sdcard_card_obj_t *)self, false);`
`383`	`383`	`if (err != ESP_OK) {`
`384`		`- return false;`
	`384`	`+ return mp_const_false;`
`385`	`385`	`}`
`386`	`386`
`387`	`387`	`mp_get_buffer_raise(buf, &bufinfo, MP_BUFFER_READ);`