py/objstr: Size-optimise failure path for mp_obj_str_get_buffer.

jimmo · jimmo · commit c7ae8c5a99fa · 2019-10-22T13:54:09.000+11:00
These fields are never looked at if the function returns non-zero.
diff --git a/py/objstr.c b/py/objstr.c
@@ -1913,9 +1913,6 @@ mp_int_t mp_obj_str_get_buffer(mp_obj_t self_in, mp_buffer_info_t *bufinfo, mp_u
         return 0;
     } else {
         // can't write to a string
-        bufinfo->buf = NULL;
-        bufinfo->len = 0;
-        bufinfo->typecode = -1;
         return 1;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1913,9 +1913,6 @@ mp_int_t mp_obj_str_get_buffer(mp_obj_t self_in, mp_buffer_info_t *bufinfo, mp_u`
`1913`	`1913`	`return 0;`
`1914`	`1914`	`} else {`
`1915`	`1915`	`// can't write to a string`
`1916`		`- bufinfo->buf = NULL;`
`1917`		`- bufinfo->len = 0;`
`1918`		`- bufinfo->typecode = -1;`
`1919`	`1916`	`return 1;`
`1920`	`1917`	`}`
`1921`	`1918`	`}`