py/emitinlinerv32: Fix compilation with ESP-IDF v5.2 and later.

agatti · agatti · commit dc2c33b07f83 · 2025-02-27T12:06:09.000+01:00
This commit fixes a compilation warning (turned error) about a
potentially uninitialised variable being used.  The warning can be
ignored as the variable in question is always written to, but the code
has been changed to silence that warning.

Signed-off-by: Alessandro Gatti &lt;a.gatti@frob.it&gt;
diff --git a/py/emitinlinerv32.c b/py/emitinlinerv32.c
@@ -709,9 +709,11 @@ static bool handle_load_store_opcode_with_offset(emit_inline_asm_t *emit, qstr o
         return false;
     }
 
-    mp_uint_t rd;
-    mp_uint_t rs1;
-    parse_register_node(nodes[0], &rd, opcode_data->argument1_kind & C);
+    mp_uint_t rd = 0;
+    mp_uint_t rs1 = 0;
+    if (!parse_register_node(nodes[0], &rd, opcode_data->argument1_kind & C)) {
+        return false;
+    }
     if (!parse_register_node(nodes[1], &rs1, opcode_data->argument3_kind & C)) {
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -709,9 +709,11 @@ static bool handle_load_store_opcode_with_offset(emit_inline_asm_t *emit, qstr o`
`709`	`709`	`return false;`
`710`	`710`	`}`
`711`	`711`
`712`		`- mp_uint_t rd;`
`713`		`- mp_uint_t rs1;`
`714`		`- parse_register_node(nodes[0], &rd, opcode_data->argument1_kind & C);`
	`712`	`+ mp_uint_t rd = 0;`
	`713`	`+ mp_uint_t rs1 = 0;`
	`714`	`+ if (!parse_register_node(nodes[0], &rd, opcode_data->argument1_kind & C)) {`
	`715`	`+ return false;`
	`716`	`+ }`
`715`	`717`	`if (!parse_register_node(nodes[1], &rs1, opcode_data->argument3_kind & C)) {`
`716`	`718`	`return false;`
`717`	`719`	`}`