Skip to content

Commit fc9a276

Browse files
committed
windows/msvc/paths.props: Dont add variant path to PyIncDirs.
This file is shared by mpy-cross.vcxproj, where PyVariant will be not set (because common.props explicitly doesn't set it when building mpy-cross). Update common.props to only add the variant path to PyIncDirs if not building mpy-cross. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
1 parent 813d559 commit fc9a276

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

ports/windows/msvc/common.props

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
<PyFileCopyCookie>$(PyBuildDir)copycookie$(Configuration)$(Platform)</PyFileCopyCookie>
2020
<CharacterSet>MultiByte</CharacterSet>
2121
</PropertyGroup>
22+
<PropertyGroup Condition="'$(PyBuildingMpyCross)' != 'True'">
23+
<PyIncDirs>$(PyIncDirs);$(PyVariantDir)</PyIncDirs>
24+
</PropertyGroup>
2225
<ItemDefinitionGroup>
2326
<ClCompile>
2427
<AdditionalIncludeDirectories>$(PyIncDirs);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>

ports/windows/msvc/paths.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
<PyVariantDir Condition="'$(PyVariantDir)' == ''">$(PyWinDir)variants\$(PyVariant)\</PyVariantDir>
3232
<PyTargetDir Condition="'$(PyTargetDir)' == ''">$(PyBuildDir)</PyTargetDir>
3333

34-
<!-- All include directories needed for uPy -->
35-
<PyIncDirs>$(PyIncDirs);$(PyBaseDir);$(PyWinDir);$(PyBuildDir);$(PyWinDir)msvc;$(PyVariantDir)</PyIncDirs>
34+
<!-- Common include directories needed for uPy -->
35+
<PyIncDirs>$(PyIncDirs);$(PyBaseDir);$(PyWinDir);$(PyBuildDir);$(PyWinDir)msvc</PyIncDirs>
3636

3737
<!-- Within PyBuildDir different subdirectories are used based on configuration and platform.
3838
By default these are chosen based on the Configuration and Platform properties, but

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy