tests/cpydiff/core_class: Document issue with super in classmethod. #15509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15509 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 161 161
Lines 21252 21252
=======================================
Hits 20918 20918
Misses 334 334 ☔ View full report in Codecov by Sentry. |
|
Thanks for the test case / report. I was curious about why the difference existed, and upon investigating managed to fix it. See #15533. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This documents an existing problem with the way
super()is implemented that became evident while I was implementing__init_subclass__, where when used inside a classmethod it defers to the ancestor of the class object itself (i.e.type), rather than parent classes it inherits from.This is probably an issue with super itself not treating the second argument differently when its a type in the way that CPython does.
Testing
I've verified this against CPython versions 3.8, 3.10, and 3.12.