py/runtime: Fix self arg passed to classmethod when accessed via super. #15533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't need #15509 if this is merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15533 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 161 161
Lines 21279 21281 +2
=======================================
+ Hits 20946 20948 +2
Misses 333 333 ☔ View full report in Codecov by Sentry. |
|
Code size report: |
Thanks to @AJMansfield for the original test case. Signed-off-by: Damien George <damien@micropython.org>
da2b739 to
233f5ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MicroPython was not conforming to CPython behaviour when using
super()within aclassmethod. This patch fixes this behaviour.Testing
New test added which did not pass before, but now passes.
Thanks to @AJMansfield for the original test case.
Trade-offs and Alternatives
This increases code size a little bit, but if not fixed it can lead to some very difficult to debug problems, if you even notice there's a problem in the first place.