Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (45e4deb) to head (4741c7c).
Report is 77 commits behind head on master.

@@            Coverage Diff             @@
##           master   #17322      +/-   ##
==========================================
- Coverage   98.54%   98.54%   -0.01%     
==========================================
  Files         169      169              
  Lines       21898    21898              
==========================================
- Hits        21580    21579       -1     
- Misses        318      319       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

Thanks for the effort.

Implemented as a standalone command rather than a --reconnect flag for consistency with other mpremote commands like resume

I have never liked that I find myself needing to type 'resume' to 95% of the commands.
I think that that resume and reconnect should be the default state, as that is what most users will expect.

• I think the main use for soft resetting before each command is automated testing, and there adding a reset is simple. But changing that behavior will need some thought, as it may be a breaking change for tools that depend on it ( although the docs say they should not)

But for this very welcome reconnect behavior, I would propose this to be the default, and to be opted out via --no-reconnect/--nrc or environment variable.

That will make the "how do we educate this" so much simpler,
Note that the resume/no-reset behavior appears to be the default for reconnect.

mpremote reconnect
Connected to MicroPython at COM10
Use Ctrl-] or Ctrl-x to exit this shell

>>> import time
>>> x=1
>>> while 1:
...     time.sleep(1)
...     print("hoi",x) 
...     x+=1
...     
...     
... 
hoi 1
hoi 2
hoi 3
hoi 4
hoi 5
hoi 6
hoi 7
hoi 8
# Unplug USB 
Device disconnected
Waiting for reconnection on COM10...
# Reconnect USB 
Connected to MicroPython at COM10
Use Ctrl-] or Ctrl-x to exit this shell
hoi 12
hoi 13
hoi 14
hoi 15
# .... snip
hoi 24
hoi 25
hoi 26
# Pressed Ctrl-]
(micropython) PS D:\mypython\micropython> mpremote reconnect
Connected to MicroPython at COM10
Use Ctrl-] or Ctrl-x to exit this shell
hoi 30
hoi 31
hoi 32
hoi 33
hoi 34
hoi 35
hoi 36
hoi 37
hoi 38
hoi 39

Thanks @Josverl for bringing up the defaults!

Yes I too have thought it would be better to have resume the default, but not entirely sure of what the range of user effects this might have. I do think resume would be less confusing for many people, with an optional reset to be used to invert that.

I'm certainly interested in this new reconnect feature being on by default, I expect to use it as my default by adding it to the local config file etc at the very least. I'd certainly be happy to make that change if we get such a concensus from the maintainers!

adding it to the local config file etc at the very least.

AFAIK mpremote finding its config file is still broken on Windows - #9573 would be needed for that

#17222 adds weight to the suggestion to make resume the default.

Particularly as more users leverage dynamic USB configuration having mpremote silently perform a soft reset is disruptive and confusing.

As I usually have multiple boards connected, I frequently want mpremote to (re)connect to a specific one.
I find the CLI for that different to my initial expectations.

Similar on linux

Even without changing default behavior, it would make a lot more sense to me if I can use the same syntax for both the connect and reconnect commands.
(possibly sharing the same implementation.)

The more complex the commands get, the more confused I get;

As an example:
To set time before connecting:

• mpremote connect com8 rtc --set exec "import time;print(time.localtime())" repl

perhaps becomes :

• mpremote connect com8 rtc --set exec "import time;print(time.localtime())" reconnect repl ❓
• mpremote connect com8 reconnect rtc --set exec "import time;print(time.localtime())" reconnect repl ❓

I have not been able to find a form that actually reconnects for this use case,
But I think it would be quite useful to set the time / connect to wifi and similar in such a scenario.

Thanks for the feedback @Josverl yes having reconnect as a separate command is not as intuitive as I'd first thought.
However I'm actually just about to push a change to make reconnect the default, with a connect --once <auto/port> option to reverse the behaviour.
I'm also going to push a separate PR to make resume the default, I believe there's support for that more broadly now.

@andrewleech Changing the defaults like this sounds very sensible to me! Feel free to request a review from me after you've had time to update.