Fix lib.includes('dom') check in containerSeemsToBeEmptyDomElement (#61481)

frodi-karlsson · web-flow · commit 29e6d6689dfb · 2025-03-25T16:24:52.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -34454,7 +34454,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     }
 
     function containerSeemsToBeEmptyDomElement(containingType: Type) {
-        return (compilerOptions.lib && !compilerOptions.lib.includes("dom")) &&
+        return (compilerOptions.lib && !compilerOptions.lib.includes("lib.dom.d.ts")) &&
             everyContainedType(containingType, type => type.symbol && /^(?:EventTarget|Node|(?:HTML[a-zA-Z]*)?Element)$/.test(unescapeLeadingUnderscores(type.symbol.escapedName))) &&
             isEmptyObjectType(containingType);
     }
diff --git a/tests/baselines/reference/missingDomElement_UsingDomLib.errors.txt b/tests/baselines/reference/missingDomElement_UsingDomLib.errors.txt
@@ -0,0 +1,10 @@
+missingDomElement_UsingDomLib.ts(3,37): error TS2339: Property 'textContent' does not exist on type 'HTMLMissingElement'.
+
+
+==== missingDomElement_UsingDomLib.ts (1 errors) ====
+    interface HTMLMissingElement {}
+    
+    (({}) as any as HTMLMissingElement).textContent;
+                                        ~~~~~~~~~~~
+!!! error TS2339: Property 'textContent' does not exist on type 'HTMLMissingElement'.
+    
diff --git a/tests/baselines/reference/missingDomElement_UsingDomLib.js b/tests/baselines/reference/missingDomElement_UsingDomLib.js
@@ -0,0 +1,10 @@
+//// [tests/cases/compiler/missingDomElement_UsingDomLib.ts] ////
+
+//// [missingDomElement_UsingDomLib.ts]
+interface HTMLMissingElement {}
+
+(({}) as any as HTMLMissingElement).textContent;
+
+
+//// [missingDomElement_UsingDomLib.js]
+({}).textContent;
diff --git a/tests/baselines/reference/missingDomElement_UsingDomLib.symbols b/tests/baselines/reference/missingDomElement_UsingDomLib.symbols
@@ -0,0 +1,9 @@
+//// [tests/cases/compiler/missingDomElement_UsingDomLib.ts] ////
+
+=== missingDomElement_UsingDomLib.ts ===
+interface HTMLMissingElement {}
+>HTMLMissingElement : Symbol(HTMLMissingElement, Decl(missingDomElement_UsingDomLib.ts, 0, 0))
+
+(({}) as any as HTMLMissingElement).textContent;
+>HTMLMissingElement : Symbol(HTMLMissingElement, Decl(missingDomElement_UsingDomLib.ts, 0, 0))
+
diff --git a/tests/baselines/reference/missingDomElement_UsingDomLib.types b/tests/baselines/reference/missingDomElement_UsingDomLib.types
@@ -0,0 +1,21 @@
+//// [tests/cases/compiler/missingDomElement_UsingDomLib.ts] ////
+
+=== missingDomElement_UsingDomLib.ts ===
+interface HTMLMissingElement {}
+
+(({}) as any as HTMLMissingElement).textContent;
+>(({}) as any as HTMLMissingElement).textContent : any
+>                                                : ^^^
+>(({}) as any as HTMLMissingElement) : HTMLMissingElement
+>                                    : ^^^^^^^^^^^^^^^^^^
+>({}) as any as HTMLMissingElement : HTMLMissingElement
+>                                  : ^^^^^^^^^^^^^^^^^^
+>({}) as any : any
+>            : ^^^
+>({}) : {}
+>     : ^^
+>{} : {}
+>   : ^^
+>textContent : any
+>            : ^^^
+
diff --git a/tests/cases/compiler/missingDomElement_UsingDomLib.ts b/tests/cases/compiler/missingDomElement_UsingDomLib.ts
@@ -0,0 +1,5 @@
+// @lib: es5,dom
+
+interface HTMLMissingElement {}
+
+(({}) as any as HTMLMissingElement).textContent;

Original file line number	Diff line number	Diff line change
`@@ -34454,7 +34454,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`34454`	`34454`	`}`
`34455`	`34455`
`34456`	`34456`	`function containerSeemsToBeEmptyDomElement(containingType: Type) {`
`34457`		`- return (compilerOptions.lib && !compilerOptions.lib.includes("dom")) &&`
	`34457`	`+ return (compilerOptions.lib && !compilerOptions.lib.includes("lib.dom.d.ts")) &&`
`34458`	`34458`	`everyContainedType(containingType, type => type.symbol && /^(?:EventTarget\|Node\|(?:HTML[a-zA-Z]*)?Element)$/.test(unescapeLeadingUnderscores(type.symbol.escapedName))) &&`
`34459`	`34459`	`isEmptyObjectType(containingType);`
`34460`	`34460`	`}`