- Minitest::TestTask enthusiastically added itself to default. (ParadoxV5)

zenspider · zenspider · commit 47959978df13 · 2023-07-17T11:11:46.000-08:00
Not everyone wants every test task added to default. This is already handled by hoe's test integration.
[git-p4: depot-paths = "//src/minitest/dev/": change = 13854]
diff --git a/lib/minitest/test_task.rb b/lib/minitest/test_task.rb
@@ -29,6 +29,10 @@ module Minitest # :nodoc:
   #   end
   #
   # Customize the name and only run unit tests.
+  #
+  # NOTE: To hook this task up to the default, make it a dependency:
+  #
+  #   task default: :unit
 
   class TestTask < Rake::TaskLib
     WINDOWS = RbConfig::CONFIG["host_os"] =~ /mswin|mingw/ # :nodoc:
@@ -157,8 +161,6 @@ def process_env
     end
 
     def define # :nodoc:
-      default_tasks = []
-
       desc "Run the test suite. Use N, X, A, and TESTOPTS to add flags/args."
       task name do
         ruby make_test_cmd, verbose:verbose
@@ -243,11 +245,6 @@ def define # :nodoc:
             "sort -n -k2 -t=",
             "tail -25"].join " | "
       end
-
-      default_tasks << name
-
-      desc "Run the default task(s)."
-      task :default => default_tasks
     end
 
     ##
