Now that we can same_schema filter by object, make sure the table exists on both side

turnstep · turnstep · commit 3abc74c70e8d · 2019-10-28T16:18:20.000Z
diff --git a/check_postgres.pl b/check_postgres.pl
@@ -7774,10 +7774,13 @@ sub schema_item_exists {
                         my $it = $itemhash->{$db1}{$item_class}{$name};
                         next if exists $it->{schemaname} and keys %{ $itemhash->{$db1}{schema} } and ! exists $itemhash->{$db2}{schema}{ $it->{schemaname} };
                     }
+
                     ## Skip if this item has a table, but the table does not match
                     if ($item_class ne 'table') {
                         my $it = $itemhash->{$db1}{$item_class}{$name};
-                        next if exists $it->{tablename} and ! exists $itemhash->{$db2}{table}{ $it->{tablename} };
+                        next if exists $it->{tablename}
+                          and exists $itemhash->{$db1}{table}{ $it->{tablename} }
+                          and exists $itemhash->{$db2}{table}{ $it->{tablename} };
                     }
 
                     my $one = '1';

Original file line number	Diff line number	Diff line change
`@@ -7774,10 +7774,13 @@ sub schema_item_exists {`
`7774`	`7774`	`my $it = $itemhash->{$db1}{$item_class}{$name};`
`7775`	`7775`	`next if exists $it->{schemaname} and keys %{ $itemhash->{$db1}{schema} } and ! exists $itemhash->{$db2}{schema}{ $it->{schemaname} };`
`7776`	`7776`	`}`
	`7777`	`+`
`7777`	`7778`	`## Skip if this item has a table, but the table does not match`
`7778`	`7779`	`if ($item_class ne 'table') {`
`7779`	`7780`	`my $it = $itemhash->{$db1}{$item_class}{$name};`
`7780`		`- next if exists $it->{tablename} and ! exists $itemhash->{$db2}{table}{ $it->{tablename} };`
	`7781`	`+ next if exists $it->{tablename}`
	`7782`	`+ and exists $itemhash->{$db1}{table}{ $it->{tablename} }`
	`7783`	`+ and exists $itemhash->{$db2}{table}{ $it->{tablename} };`
`7781`	`7784`	`}`
`7782`	`7785`
`7783`	`7786`	`my $one = '1';`