fix: Use monstarlab_lints : : (#133)

nivisi · web-flow · commit c6fad203cc6b · 2024-01-15T18:14:52.000+06:00
* fix: Use monstarlab_lints : :

* fix: Configure lints dependency correctly

* nit: FIx warnings
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -5,78 +5,14 @@
 # IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be
 # invoked from the command line by running `flutter analyze`.
 
-# The following line activates a set of recommended lints for Flutter apps,
-# packages, and plugins designed to encourage good coding practices.
-include: package:flutter_lints/flutter.yaml
-
-linter:
-  rules:
-    # https://github.com/dart-lang/linter/blob/master/example/all.yaml
-    - always_declare_return_types
-    - always_require_non_null_named_parameters
-    - annotate_overrides
-    - avoid_init_to_null
-    - avoid_null_checks_in_equality_operators
-    - avoid_print
-    - avoid_relative_lib_imports
-    - avoid_return_types_on_setters
-    - avoid_shadowing_type_parameters
-    - avoid_single_cascade_in_expression_statements
-    - avoid_types_as_parameter_names
-    - avoid_unnecessary_containers
-    - avoid_unused_constructor_parameters
-    - avoid_void_async
-    - await_only_futures
-    - camel_case_extensions
-    - curly_braces_in_flow_control_structures
-    - empty_catches
-    - empty_constructor_bodies
-    - library_names
-    - library_prefixes
-    - no_duplicate_case_values
-    - null_closures
-    - omit_local_variable_types
-    - prefer_adjacent_string_concatenation
-    - prefer_collection_literals
-    - prefer_conditional_assignment
-    - prefer_contains
-    - prefer_final_fields
-    - prefer_for_elements_to_map_fromIterable
-    - prefer_generic_function_type_aliases
-    - prefer_if_null_operators
-    - prefer_inlined_adds
-    - prefer_is_empty
-    - prefer_is_not_empty
-    - prefer_iterable_whereType
-    - prefer_single_quotes
-    - prefer_spread_collections
-    - recursive_getters
-    - slash_for_doc_comments
-    - sort_child_properties_last
-    - type_init_formals
-    - unawaited_futures
-    - unnecessary_brace_in_string_interps
-    - unnecessary_const
-    - unnecessary_getters_setters
-    - unnecessary_new
-    - unnecessary_null_in_if_null_operators
-    - unnecessary_this
-    - unrelated_type_equality_checks
-    - unsafe_html
-    - use_colored_box
-    - use_decorated_box
-    - use_full_hex_values_for_flutter_colors
-    - use_function_type_syntax_for_parameters
-    - use_rethrow_when_possible
-    - valid_regexps
+include: package:monstarlab_lints/analysis_options.yaml
 
 # Additional information about this file can be found at
 # https://dart.dev/guides/language/analysis-options
 
-
 analyzer:
   errors:
-    # Ignore invalid annotations since freezed annotation and json serializable required it 
+    # Ignore invalid annotations since freezed annotation and json serializable required it
     invalid_annotation_target: ignore
   exclude:
     # ignore DI
diff --git a/lib/data/interceptor/auth_interceptor.dart b/lib/data/interceptor/auth_interceptor.dart
@@ -116,7 +116,7 @@ class AuthInterceptor extends InterceptorsWrapper {
         headers: {
           'Authorization': 'Bearer ${authPreferences.refreshToken}',
           MetaInterceptor.nMetaHeaderKey:
-              requestOptions.headers[MetaInterceptor.nMetaHeaderKey]
+              requestOptions.headers[MetaInterceptor.nMetaHeaderKey],
         },
       );
 
diff --git a/lib/data/services/response_objects/tokens_response.dart b/lib/data/services/response_objects/tokens_response.dart
@@ -22,7 +22,7 @@ class TokensResponse with _$TokensResponse {
       'accessToken': 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwY2MiO',
       'refreshToken': 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwY2Mi',
       'tokenType': 'Bearer',
-      'expiresIn': 2592000
+      'expiresIn': 2592000,
     });
   }
 
diff --git a/lib/injection/dependencies.dart b/lib/injection/dependencies.dart
@@ -1,8 +1,7 @@
+import 'package:flutter_template/injection/injector.dart';
 import 'package:flutter_template/presentation/app_flavor.dart';
 import 'package:flutter_template/presentation/routes/router.dart';
 
-import 'injector.dart';
-
 class DependencyManager {
   static Future<void> inject(AppFlavor flavor) async {
     injector.registerLazySingleton<AppFlavor>(() => flavor);
diff --git a/lib/main_common.dart b/lib/main_common.dart
@@ -1,8 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_template/injection/dependencies.dart';
 import 'package:flutter_template/presentation/app.dart';
-
-import 'presentation/app_flavor.dart';
+import 'package:flutter_template/presentation/app_flavor.dart';
 
 // ignore: avoid_void_async
 void mainCommon(AppFlavor flavor) async {
diff --git a/lib/main_development.dart b/lib/main_development.dart
@@ -1,5 +1,5 @@
-import 'presentation/app_flavor.dart';
-import 'main_common.dart';
+import 'package:flutter_template/main_common.dart';
+import 'package:flutter_template/presentation/app_flavor.dart';
 
 void main() async {
   const config = AppFlavor.development;
diff --git a/lib/main_production.dart b/lib/main_production.dart
@@ -1,5 +1,5 @@
-import 'presentation/app_flavor.dart';
-import 'main_common.dart';
+import 'package:flutter_template/main_common.dart';
+import 'package:flutter_template/presentation/app_flavor.dart';
 
 void main() async {
   const config = AppFlavor.production;
diff --git a/lib/main_staging.dart b/lib/main_staging.dart
@@ -1,5 +1,5 @@
-import 'presentation/app_flavor.dart';
-import 'main_common.dart';
+import 'package:flutter_template/main_common.dart';
+import 'package:flutter_template/presentation/app_flavor.dart';
 
 void main() async {
   const config = AppFlavor.staging;
diff --git a/lib/presentation/app.dart b/lib/presentation/app.dart
@@ -1,9 +1,9 @@
 import 'package:auto_route/auto_route.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_template/injection/injector.dart';
+import 'package:flutter_template/nstack/nstack.dart';
 import 'package:flutter_template/presentation/resources/resources.dart';
 import 'package:flutter_template/presentation/routes/router.dart';
-import '../../nstack/nstack.dart';
 
 class App extends StatelessWidget {
   const App({Key? key}) : super(key: key);
diff --git a/lib/presentation/feature/profile/profile_page.dart b/lib/presentation/feature/profile/profile_page.dart
@@ -41,14 +41,15 @@ class _ProfilePageState extends State<ProfilePage> {
             child: Column(
               children: [
                 BlocBuilder<ProfileCubit, ProfileState>(
-                    bloc: _profilePresenter,
-                    builder: (context, state) {
-                      if (state.isLoading) {
-                        return const CircularProgressIndicator();
-                      } else {
-                        return Text('Hi ${state.name}!');
-                      }
-                    })
+                  bloc: _profilePresenter,
+                  builder: (context, state) {
+                    if (state.isLoading) {
+                      return const CircularProgressIndicator();
+                    } else {
+                      return Text('Hi ${state.name}!');
+                    }
+                  },
+                ),
               ],
             ),
           ),
diff --git a/lib/presentation/utils/not_implemented_dialog/not_implemented_dialog.dart b/lib/presentation/utils/not_implemented_dialog/not_implemented_dialog.dart
@@ -29,7 +29,7 @@ class NotImplementedDialog extends StatelessWidget {
         TextButton(
           onPressed: Navigator.of(context).pop,
           child: const Text('OK'),
-        )
+        ),
       ],
     );
   }
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -58,7 +58,7 @@ dev_dependencies:
   freezed: ^2.4.6
   json_serializable: ^6.7.1
   auto_route_generator: ^7.3.2
-  flutter_lints: ^2.0.1
+  monstarlab_lints: ^1.0.2
 
   # Simplifed work with assets
   flutter_gen_runner: ^5.4.0

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class TokensResponse with _$TokensResponse {`
`22`	`22`	`'accessToken': 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwY2MiO',`
`23`	`23`	`'refreshToken': 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwY2Mi',`
`24`	`24`	`'tokenType': 'Bearer',`
`25`		`- 'expiresIn': 2592000`
	`25`	`+ 'expiresIn': 2592000,`
`26`	`26`	`});`
`27`	`27`	`}`
`28`	`28`