Bug X - Make django-rest-framework test requests use content_type json

Ed Morley · Ed Morley · commit 0ac15f268e2b · 2015-11-13T00:30:53.000Z
The default format used to make test requests is `multipart/form-data`, unless overridden using `TEST_REQUEST_DEFAULT_FORMAT`: http://www.django-rest-framework.org/api-guide/testing/#setting-the-default-format Our API only accepts json and html (see `DEFAULT_RENDERER_CLASSES`), so we should have always been setting `TEST_REQUEST_DEFAULT_FORMAT` to `json`, to prevent test failures. However until recently there was a bug preventing those failures: encode/django-rest-framework#3214 Which has now been fixed in django-rest-framwork v3.3.x: encode/django-rest-framework#3410 ...so we must fix this before updating to the latest version of d-r-f.
diff --git a/treeherder/config/settings.py b/treeherder/config/settings.py
@@ -283,7 +283,8 @@
         'rest_framework.authentication.SessionAuthentication',
         'hawkrest.HawkAuthentication',
         'treeherder.webapp.api.auth.TwoLeggedOauthAuthentication',
-    )
+    ),
+    'TEST_REQUEST_DEFAULT_FORMAT': 'json',
 }
 
 SITE_URL = os.environ.get("SITE_URL", "http://local.treeherder.mozilla.org")

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,8 @@`
`283`	`283`	`'rest_framework.authentication.SessionAuthentication',`
`284`	`284`	`'hawkrest.HawkAuthentication',`
`285`	`285`	`'treeherder.webapp.api.auth.TwoLeggedOauthAuthentication',`
`286`		`- )`
	`286`	`+ ),`
	`287`	`+ 'TEST_REQUEST_DEFAULT_FORMAT': 'json',`
`287`	`288`	`}`
`288`	`289`
`289`	`290`	`SITE_URL = os.environ.get("SITE_URL", "http://local.treeherder.mozilla.org")`