Skip to content

Suggestions for limt() and offset() improvements to SelectDSL #837

@mailingfeng

Description

@mailingfeng

Version: 1.5.2

Question

There are paging or non-paging query scenarios.

In API design, offset[Long] and limit[Long] are generally used.
When a non-paginated scenario is required, the arguments offset=null and limit=null are passed in.

However, the current arguments to limit() and offset() are long, which requires a non-null check on RequestBean's limit and offset, which is not elegant enough.

    public LimitFinisher limit(long limit) {
        this.limit = limit;
        return new LimitFinisher();
    }

    public OffsetFirstFinisher offset(long offset) {
        this.offset = offset;
        return new OffsetFirstFinisher();
    }

Suggestion

The arguments to limit() and offset() are changed to Long, which is not change the current code logic.

ps: same to other xxxDSL

Looking forward to your reply~!

    public LimitFinisher limit(Long limit) {
        this.limit = limit;
        return new LimitFinisher();
    }

    public OffsetFirstFinisher offset(Long offset) {
        this.offset = offset;
        return new OffsetFirstFinisher();
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy