Fix challenge.track validation

luizrrodrigues · mtwomey · commit 0a44b2e2ffde · 2020-08-13T23:04:34.000-05:00
diff --git a/src/reducers/challenge.js b/src/reducers/challenge.js
@@ -18,6 +18,8 @@ import { fireErrorMessage } from '../utils/errors';
 
 import mySubmissionsManagement from './my-submissions-management';
 
+import { COMPETITION_TRACKS } from '../utils/tc';
+
 /**
  * Handles CHALLENGE/GET_DETAILS_INIT action.
  * @param {Object} state
@@ -469,7 +471,7 @@ export function factory(options = {}) {
       const challengeDetails = _.get(res, 'payload', {});
       const track = _.get(challengeDetails, 'legacy.track', '');
       let checkpointsPromise = null;
-      if (track === 'DESIGN') {
+      if (track === COMPETITION_TRACKS.DESIGN) {
         const p = _.get(challengeDetails, 'phases', [])
           .filter(x => x.name === 'Checkpoint Review');
         if (p.length && !p[0].isOpen) {
diff --git a/src/services/challenges.js b/src/services/challenges.js
@@ -636,7 +636,7 @@ class ChallengesService {
     let contentType;
     let url;
 
-    if (track === 'DESIGN') {
+    if (track === COMPETITION_TRACKS.DESIGN) {
       ({ api } = this.private);
       contentType = 'application/json';
       url = '/submissions/'; // The submission info is contained entirely in the JSON body
@@ -654,7 +654,7 @@ class ChallengesService {
     }, onProgress).then((res) => {
       const jres = JSON.parse(res);
       // Return result for Develop submission
-      if (track === 'DEVELOP') {
+      if (track === COMPETITION_TRACKS.DEVELOP) {
         return jres;
       }
       // Design Submission requires an extra "Processing" POST
diff --git a/src/utils/challenge/filter.js b/src/utils/challenge/filter.js
@@ -89,7 +89,7 @@ function filterByRegistrationOpen(challenge, state) {
     if (!registrationPhase || !registrationPhase.isOpen) {
       return false;
     }
-    if (challenge.track === 'DESIGN') {
+    if (challenge.track === COMPETITION_TRACKS.DESIGN) {
       const checkpointPhase = challengePhases.find(item => item.name === 'Checkpoint Submission')[0];
       return !checkpointPhase || !checkpointPhase.isOpen;
     }

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ function filterByRegistrationOpen(challenge, state) {`
`89`	`89`	`if (!registrationPhase \|\| !registrationPhase.isOpen) {`
`90`	`90`	`return false;`
`91`	`91`	`}`
`92`		`- if (challenge.track === 'DESIGN') {`
	`92`	`+ if (challenge.track === COMPETITION_TRACKS.DESIGN) {`
`93`	`93`	`const checkpointPhase = challengePhases.find(item => item.name === 'Checkpoint Submission')[0];`
`94`	`94`	`return !checkpointPhase \|\| !checkpointPhase.isOpen;`
`95`	`95`	`}`